pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pgcrypto: Check for error return of px_cipher_decrypt() 5+ messages / 2 participants [nested] [flat]
* pgsql: pgcrypto: Check for error return of px_cipher_decrypt() @ 2021-03-23 10:51 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 5+ messages in thread From: Peter Eisentraut @ 2021-03-23 10:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the higher-level functions would return garbage. The nearby encryption code already handled errors similarly. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/22e1943f13b66df22ea4f8d15836411ba259263a Modified Files -------------- contrib/pgcrypto/px.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pgcrypto: Check for error return of px_cipher_decrypt() @ 2021-09-25 09:47 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2021-09-25 09:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the higher-level functions would return garbage. The nearby encryption code already handled errors similarly. Author: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com Backpatch-through: 9.6 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a69e1506f618d4577bf7fdbfea51924a44c6e7de Modified Files -------------- contrib/pgcrypto/px.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pgcrypto: Check for error return of px_cipher_decrypt() @ 2021-09-25 09:48 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2021-09-25 09:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the higher-level functions would return garbage. The nearby encryption code already handled errors similarly. Author: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com Backpatch-through: 9.6 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/90cfd269f226ecf287df7b8df04f6a46515000d4 Modified Files -------------- contrib/pgcrypto/px.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pgcrypto: Check for error return of px_cipher_decrypt() @ 2021-09-25 09:48 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2021-09-25 09:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the higher-level functions would return garbage. The nearby encryption code already handled errors similarly. Author: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com Backpatch-through: 9.6 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0f28d267c7e0936b55307d88644070248a718bd7 Modified Files -------------- contrib/pgcrypto/px.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pgcrypto: Check for error return of px_cipher_decrypt() @ 2021-09-25 09:49 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Daniel Gustafsson @ 2021-09-25 09:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the higher-level functions would return garbage. The nearby encryption code already handled errors similarly. Author: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com Backpatch-through: 9.6 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/841075a65cdc2d034dd8a473f25c5f584c8856d7 Modified Files -------------- contrib/pgcrypto/px.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2021-09-25 09:49 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-23 10:51 pgsql: pgcrypto: Check for error return of px_cipher_decrypt() Peter Eisentraut <peter@eisentraut.org> 2021-09-25 09:47 pgsql: pgcrypto: Check for error return of px_cipher_decrypt() Daniel Gustafsson <dgustafsson@postgresql.org> 2021-09-25 09:48 pgsql: pgcrypto: Check for error return of px_cipher_decrypt() Daniel Gustafsson <dgustafsson@postgresql.org> 2021-09-25 09:48 pgsql: pgcrypto: Check for error return of px_cipher_decrypt() Daniel Gustafsson <dgustafsson@postgresql.org> 2021-09-25 09:49 pgsql: pgcrypto: Check for error return of px_cipher_decrypt() Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox