pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix instability in contrib/bloom TAP tests. 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix instability in contrib/bloom TAP tests. @ 2021-09-28 21:34 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2021-09-28 21:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix instability in contrib/bloom TAP tests. It turns out that the instability complained of in commit d3c09b9b1 has an embarrassingly simple explanation. The test script waits for the standby to flush incoming WAL to disk, but it should wait for the WAL to be replayed, since we are testing for the effects of that to be visible. While at it, use wait_for_catchup instead of reinventing that logic, and adjust $Test::Builder::Level to improve future error reports. Back-patch to v12 where the necessary infrastructure came in (cf. aforesaid commit). Also back-patch 7d1aa6bf1 so that the test will actually get run. Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6bc6bd47cf715c8717a8af3f617957045772d38b Modified Files -------------- contrib/bloom/t/001_wal.pl | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix instability in contrib/bloom TAP tests. @ 2021-09-28 21:34 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2021-09-28 21:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix instability in contrib/bloom TAP tests. It turns out that the instability complained of in commit d3c09b9b1 has an embarrassingly simple explanation. The test script waits for the standby to flush incoming WAL to disk, but it should wait for the WAL to be replayed, since we are testing for the effects of that to be visible. While at it, use wait_for_catchup instead of reinventing that logic, and adjust $Test::Builder::Level to improve future error reports. Back-patch to v12 where the necessary infrastructure came in (cf. aforesaid commit). Also back-patch 7d1aa6bf1 so that the test will actually get run. Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cea5624f6a23a100fb93aee8b40bdc3a8cb52081 Modified Files -------------- contrib/bloom/Makefile | 4 +--- contrib/bloom/t/001_wal.pl | 8 +++----- 2 files changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix instability in contrib/bloom TAP tests. @ 2021-09-28 21:34 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2021-09-28 21:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix instability in contrib/bloom TAP tests. It turns out that the instability complained of in commit d3c09b9b1 has an embarrassingly simple explanation. The test script waits for the standby to flush incoming WAL to disk, but it should wait for the WAL to be replayed, since we are testing for the effects of that to be visible. While at it, use wait_for_catchup instead of reinventing that logic, and adjust $Test::Builder::Level to improve future error reports. Back-patch to v12 where the necessary infrastructure came in (cf. aforesaid commit). Also back-patch 7d1aa6bf1 so that the test will actually get run. Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cf26a8d8a75ff4ae78bf0818ebb2bf6cf90db69c Modified Files -------------- contrib/bloom/Makefile | 4 +--- contrib/bloom/t/001_wal.pl | 8 +++----- 2 files changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix instability in contrib/bloom TAP tests. @ 2021-09-28 21:34 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2021-09-28 21:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix instability in contrib/bloom TAP tests. It turns out that the instability complained of in commit d3c09b9b1 has an embarrassingly simple explanation. The test script waits for the standby to flush incoming WAL to disk, but it should wait for the WAL to be replayed, since we are testing for the effects of that to be visible. While at it, use wait_for_catchup instead of reinventing that logic, and adjust $Test::Builder::Level to improve future error reports. Back-patch to v12 where the necessary infrastructure came in (cf. aforesaid commit). Also back-patch 7d1aa6bf1 so that the test will actually get run. Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2d8a8b18fe5a88146cb8baff591137fa724d86da Modified Files -------------- contrib/bloom/Makefile | 4 +--- contrib/bloom/t/001_wal.pl | 8 +++----- 2 files changed, 4 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-09-28 21:34 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-28 21:34 pgsql: Fix instability in contrib/bloom TAP tests. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-28 21:34 pgsql: Fix instability in contrib/bloom TAP tests. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-28 21:34 pgsql: Fix instability in contrib/bloom TAP tests. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-28 21:34 pgsql: Fix instability in contrib/bloom TAP tests. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox