pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix parallel operations that prevent oldest xmin from advancing. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix parallel operations that prevent oldest xmin from advancing. @ 2021-11-19 04:02 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-11-19 04:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix parallel operations that prevent oldest xmin from advancing. While determining xid horizons, we skip over backends that are running Vacuum. We also ignore Create Index Concurrently, or Reindex Concurrently for the purposes of computing Xmin for Vacuum. But we were not setting the flags corresponding to these operations when they are performed in parallel which was preventing Xid horizon from advancing. The optimization related to skipping Create Index Concurrently, or Reindex Concurrently operations was implemented in PG-14 but the fix is the same for the Parallel Vacuum as well so back-patched till PG-13. Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAD21AoCLQqgM1sXh9BrDFq0uzd3RBFKi=Vfo6cjjKODm0Onr5w@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/33b6dd83e26f06c96e7d54af534a70476749cbab Modified Files -------------- src/backend/access/heap/vacuumlazy.c | 6 ++++++ src/backend/storage/ipc/procarray.c | 16 ++++++++++++++-- src/include/storage/proc.h | 7 +++++++ 3 files changed, 27 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix parallel operations that prevent oldest xmin from advancing. @ 2021-11-19 04:02 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-11-19 04:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix parallel operations that prevent oldest xmin from advancing. While determining xid horizons, we skip over backends that are running Vacuum. We also ignore Create Index Concurrently, or Reindex Concurrently for the purposes of computing Xmin for Vacuum. But we were not setting the flags corresponding to these operations when they are performed in parallel which was preventing Xid horizon from advancing. The optimization related to skipping Create Index Concurrently, or Reindex Concurrently operations was implemented in PG-14 but the fix is the same for the Parallel Vacuum as well so back-patched till PG-13. Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAD21AoCLQqgM1sXh9BrDFq0uzd3RBFKi=Vfo6cjjKODm0Onr5w@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ead49ebc07a7eaae4d57008dd7fd1f3d71fa1ec4 Modified Files -------------- src/backend/access/heap/vacuumlazy.c | 6 ++++++ src/backend/access/nbtree/nbtsort.c | 7 +++++++ src/backend/storage/ipc/procarray.c | 17 +++++++++++++++-- src/include/storage/proc.h | 7 +++++++ 4 files changed, 35 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix parallel operations that prevent oldest xmin from advancing. @ 2021-11-19 04:02 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-11-19 04:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix parallel operations that prevent oldest xmin from advancing. While determining xid horizons, we skip over backends that are running Vacuum. We also ignore Create Index Concurrently, or Reindex Concurrently for the purposes of computing Xmin for Vacuum. But we were not setting the flags corresponding to these operations when they are performed in parallel which was preventing Xid horizon from advancing. The optimization related to skipping Create Index Concurrently, or Reindex Concurrently operations was implemented in PG-14 but the fix is the same for the Parallel Vacuum as well so back-patched till PG-13. Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/CAD21AoCLQqgM1sXh9BrDFq0uzd3RBFKi=Vfo6cjjKODm0Onr5w@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0f0cfb494004befb0f6e89d3129347869420c509 Modified Files -------------- src/backend/access/heap/vacuumlazy.c | 6 ++++++ src/backend/access/nbtree/nbtsort.c | 7 +++++++ src/backend/storage/ipc/procarray.c | 17 +++++++++++++++-- src/include/storage/proc.h | 7 +++++++ 4 files changed, 35 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-11-19 04:02 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-19 04:02 pgsql: Fix parallel operations that prevent oldest xmin from advancing. Amit Kapila <akapila@postgresql.org> 2021-11-19 04:02 pgsql: Fix parallel operations that prevent oldest xmin from advancing. Amit Kapila <akapila@postgresql.org> 2021-11-19 04:02 pgsql: Fix parallel operations that prevent oldest xmin from advancing. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox