pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password 6+ messages / 1 participants [nested] [flat]
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3ce5d0884c564cbb1de1e6997c2b557f558e6398 Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 22 ++++++++++++---------- 2 files changed, 20 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/93295932d1f48a929a569a2326c150a2eb060453 Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 22 ++++++++++++---------- 2 files changed, 20 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3bd7556bbe0ade42552e3a094c3b0fd99039854e Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 22 ++++++++++++---------- 2 files changed, 20 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/282b6d00abf5cebece6f94c796a4ed807a0176db Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 23 ++++++++++++----------- 2 files changed, 20 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c2242d3640eadbe42556aad2f37eae393e84a4df Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 22 ++++++++++++---------- 2 files changed, 20 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password @ 2021-11-21 19:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-21 19:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_receivewal, pg_recvlogical: allow canceling initial password prompt. Previously it was impossible to terminate these programs via control-C while they were prompting for a password. We can fix that trivially for their initial password prompts, by moving setup of the SIGINT handler from just before to just after their initial GetConnection() calls. This fix doesn't permit escaping out of later re-prompts, but those should be exceedingly rare, since the user's password or the server's authentication setup would have to have changed meanwhile. We considered applying a fix similar to commit 46d665bc2, but that seemed more complicated than it'd be worth. Moreover, this way is back-patchable, which that wasn't. The misbehavior exists in all supported versions, so back-patch to all. Tom Lane and Nathan Bossart Discussion: https://postgr.es/m/747443.1635536754@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/33edf4a3ca4c1fdb7665ea3a4d01bb5fc7477117 Modified Files -------------- src/bin/pg_basebackup/pg_receivewal.c | 12 ++++++++---- src/bin/pg_basebackup/pg_recvlogical.c | 22 ++++++++++++---------- 2 files changed, 20 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-11-21 19:14 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us> 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us> 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us> 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us> 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us> 2021-11-21 19:14 pgsql: pg_receivewal, pg_recvlogical: allow canceling initial password Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox