pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/72cf39d51ade63954c868bfe93996b4be7a79bf5 Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ef41c3fd6c86d6fa504144996b339704347322c9 Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d24dac9549067716f5b4d8e44ccf87dd5274bfcd Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/44bd3ed332d6ad3207f38b3b6deb6083f0baddf5 Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9c6ab1ef338273850c8c33f808d27486d3c5ad76 Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD @ 2021-11-26 15:47 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 6+ messages in thread From: Alvaro Herrera @ 2021-11-26 15:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2c3fddcbbd8aa542beec8e3abf3369168517174e Modified Files -------------- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-11-26 15:47 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org> 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org> 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org> 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org> 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org> 2021-11-26 15:47 pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox