pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: isolationtester: append session name to application_name.
8+ messages / 2 participants
[nested] [flat]
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:05 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:05 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3f323956128ff8589ce4d3a14e8b950837831803
Modified Files
--------------
.../expected/insert-conflict-specconflict.out | 20 ++++++++--------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++--
.../specs/insert-conflict-specconflict.spec | 5 +---
3 files changed, 37 insertions(+), 16 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:05 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:05 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5b5455b035c62a710ebd6facb164112e36e9fa49
Modified Files
--------------
.../expected/insert-conflict-specconflict.out | 20 ++++++++--------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++--
.../specs/insert-conflict-specconflict.spec | 5 +---
3 files changed, 37 insertions(+), 16 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:06 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:06 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/65f860e78a04f4f035dcec04c5c796793113dfba
Modified Files
--------------
.../expected/insert-conflict-specconflict.out | 20 ++++++++--------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++--
.../specs/insert-conflict-specconflict.spec | 5 +---
3 files changed, 37 insertions(+), 16 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:06 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:06 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a5fe66bfdaec7add9381b61b33f5c361eaacd055
Modified Files
--------------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:06 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:06 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c99fd65fa207d2a08a780b2af5336322835b1568
Modified Files
--------------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: isolationtester: append session name to application_name.
@ 2021-12-13 20:06 Andres Freund <andres@anarazel.de>
2021-12-14 01:49 ` Re: pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 8+ messages in thread
From: Andres Freund @ 2021-12-13 20:06 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
isolationtester: append session name to application_name.
When writing / debugging an isolation test it sometimes is useful to see which
session holds what lock etc. To make it easier, both as part of spec files and
interactively, append the session name to application_name. Since b1907d688
application_name already contains the test name, this appends the session's
name to that.
insert-conflict-specconflict did something like this manually, which can now
be removed.
As we have done lately with other test infrastructure improvements, backpatch
this change, to make it easier to backpatch tests.
Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Michael Paquier <michael@paquier.xyz>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
Backpatch: 10-, to make backpatching of tests easier.
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/dbc5cdd5cbb8b9f98b880c0e49d613729bf1b839
Modified Files
--------------
src/test/isolation/isolationtester.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: isolationtester: append session name to application_name.
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
@ 2021-12-14 01:49 ` Andres Freund <andres@anarazel.de>
2021-12-14 02:00 ` Re: pgsql: isolationtester: append session name to application_name. Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 8+ messages in thread
From: Andres Freund @ 2021-12-14 01:49 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Hi,
On 2021-12-13 20:06:10 +0000, Andres Freund wrote:
> isolationtester: append session name to application_name.
>
> When writing / debugging an isolation test it sometimes is useful to see which
> session holds what lock etc. To make it easier, both as part of spec files and
> interactively, append the session name to application_name. Since b1907d688
> application_name already contains the test name, this appends the session's
> name to that.
>
> insert-conflict-specconflict did something like this manually, which can now
> be removed.
>
> As we have done lately with other test infrastructure improvements, backpatch
> this change, to make it easier to backpatch tests.
>
> Author: Andres Freund <andres@anarazel.de>
> Reviewed-By: Michael Paquier <michael@paquier.xyz>
> Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
> Discussion: https://postgr.es/m/20211211012052.2blmzcmxnxqawd2z@alap3.anarazel.de
> Backpatch: 10-, to make backpatching of tests easier.
Eeelpout failed 020_archive_status.pl with
error running SQL: 'psql:<stdin>:1: ERROR: checkpoint request failed
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=eelpout&dt=021-12-13%2020%3A16%3A06
after this and the preceding commit.
As neither of two commits since the last successful run touched anything
relevant to tap tests or checkpoints I'm assuming it's just chance that eelput
failed right now.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: isolationtester: append session name to application_name.
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-14 01:49 ` Re: pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
@ 2021-12-14 02:00 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 8+ messages in thread
From: Michael Paquier @ 2021-12-14 02:00 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
On Mon, Dec 13, 2021 at 05:49:49PM -0800, Andres Freund wrote:
> Eeelpout failed 020_archive_status.pl with
> error running SQL: 'psql:<stdin>:1: ERROR: checkpoint request failed
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=eelpout&dt=021-12-13%2020%3A16%3A06
> after this and the preceding commit.
>
> As neither of two commits since the last successful run touched anything
> relevant to tap tests or checkpoints I'm assuming it's just chance that eelput
> failed right now.
Noah has reported this failure coming from the buildfarm in the past,
so that's unrelated.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2021-12-14 02:00 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 20:05 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-13 20:05 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-13 20:06 pgsql: isolationtester: append session name to application_name. Andres Freund <andres@anarazel.de>
2021-12-14 01:49 ` Andres Freund <andres@anarazel.de>
2021-12-14 02:00 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox