pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove assertion for replication origins in PREPARE TRANSACTION 5+ messages / 1 participants [nested] [flat]
* pgsql: Remove assertion for replication origins in PREPARE TRANSACTION @ 2021-12-14 01:59 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2021-12-14 01:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario. Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz Backpatch-through: 11 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ece8c76192fee0b78509688325631ceabca44ff5 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove assertion for replication origins in PREPARE TRANSACTION @ 2021-12-14 01:59 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2021-12-14 01:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario. Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz Backpatch-through: 11 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4be3e005e5da931aa816e3c04e1217c33de52fd6 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove assertion for replication origins in PREPARE TRANSACTION @ 2021-12-14 01:59 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2021-12-14 01:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario. Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz Backpatch-through: 11 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3f710fc2b48d6326958260f10bd139a1e87fcf53 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove assertion for replication origins in PREPARE TRANSACTION @ 2021-12-14 01:59 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2021-12-14 01:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario. Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz Backpatch-through: 11 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/65af1e842208cf3edec3b74842eec87b4a0138e5 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove assertion for replication origins in PREPARE TRANSACTION @ 2021-12-14 01:59 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 5+ messages in thread From: Michael Paquier @ 2021-12-14 01:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove assertion for replication origins in PREPARE TRANSACTION When using replication origins, pg_replication_origin_xact_setup() is an optional choice to be able to set a LSN and a timestamp to mark the origin, which would be additionally added to WAL for transaction commits or aborts (including 2PC transactions). An assertion in the code path of PREPARE TRANSACTION assumed that this data should always be set, so it would trigger when using replication origins without setting up an origin LSN. Some tests are added to cover more this kind of scenario. Oversight in commit 1eb6d65. Per discussion with Amit Kapila and Masahiko Sawada. Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz Backpatch-through: 11 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8abb6c27ec7538a4975544896c35e2f9a73a9f30 Modified Files -------------- contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++ contrib/test_decoding/sql/replorigin.sql | 32 +++++++++++ src/backend/access/transam/twophase.c | 1 - 3 files changed, 108 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2021-12-14 01:59 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-12-14 01:59 pgsql: Remove assertion for replication origins in PREPARE TRANSACTION Michael Paquier <michael@paquier.xyz> 2021-12-14 01:59 pgsql: Remove assertion for replication origins in PREPARE TRANSACTION Michael Paquier <michael@paquier.xyz> 2021-12-14 01:59 pgsql: Remove assertion for replication origins in PREPARE TRANSACTION Michael Paquier <michael@paquier.xyz> 2021-12-14 01:59 pgsql: Remove assertion for replication origins in PREPARE TRANSACTION Michael Paquier <michael@paquier.xyz> 2021-12-14 01:59 pgsql: Remove assertion for replication origins in PREPARE TRANSACTION Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox