pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix datatype confusion in logtape.c's right_offset().
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix datatype confusion in logtape.c's right_offset().
@ 2021-12-14 16:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2021-12-14 16:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix datatype confusion in logtape.c's right_offset().

This could only matter if (a) long is wider than int, and (b) the heap
of free blocks exceeds UINT_MAX entries, which seems pretty unlikely.
Still, it's a theoretical bug, so backpatch to v13 where the typo came
in (in commit c02fdc922).

In passing, also make swap_nodes() use consistent datatypes.

Ma Liangzhu

Discussion: https://postgr.es/m/17336-fc4e522d26a750fd@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2de3c1015cb2556af501c630b1768a20f111fe95

Modified Files
--------------
src/backend/utils/sort/logtape.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix datatype confusion in logtape.c's right_offset().
@ 2021-12-14 16:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2021-12-14 16:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix datatype confusion in logtape.c's right_offset().

This could only matter if (a) long is wider than int, and (b) the heap
of free blocks exceeds UINT_MAX entries, which seems pretty unlikely.
Still, it's a theoretical bug, so backpatch to v13 where the typo came
in (in commit c02fdc922).

In passing, also make swap_nodes() use consistent datatypes.

Ma Liangzhu

Discussion: https://postgr.es/m/17336-fc4e522d26a750fd@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/25c7faa1feeeff040242100d61b1f8914db3d3ea

Modified Files
--------------
src/backend/utils/sort/logtape.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix datatype confusion in logtape.c's right_offset().
@ 2021-12-14 16:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2021-12-14 16:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix datatype confusion in logtape.c's right_offset().

This could only matter if (a) long is wider than int, and (b) the heap
of free blocks exceeds UINT_MAX entries, which seems pretty unlikely.
Still, it's a theoretical bug, so backpatch to v13 where the typo came
in (in commit c02fdc922).

In passing, also make swap_nodes() use consistent datatypes.

Ma Liangzhu

Discussion: https://postgr.es/m/17336-fc4e522d26a750fd@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0a5682041dbf991bd325a7d14daf39ecfc9bd624

Modified Files
--------------
src/backend/utils/sort/logtape.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2021-12-14 16:47 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 16:47 pgsql: Fix datatype confusion in logtape.c's right_offset(). Tom Lane <tgl@sss.pgh.pa.us>
2021-12-14 16:47 pgsql: Fix datatype confusion in logtape.c's right_offset(). Tom Lane <tgl@sss.pgh.pa.us>
2021-12-14 16:47 pgsql: Fix datatype confusion in logtape.c's right_offset(). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox