pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Adjust behavior of some env settings for the TAP tests of MSVC 6+ messages / 1 participants [nested] [flat]
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7acd01015c4a5edb253ea9468ccb71ef99cabd1a Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4ddbd7456a2d1a2f06f0860151bcbc720bf75e55 Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aadbf825b7c41e241d27dc4d8ed7d77fc4718634 Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f04aa65daf597e2f9eb1e79c553c62adbbe3b897 Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/304345bd7951e601cc6eb01f261059fecf5e606b Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adjust behavior of some env settings for the TAP tests of MSVC @ 2021-12-15 01:41 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2021-12-15 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adjust behavior of some env settings for the TAP tests of MSVC edc2332 has introduced in vcregress.pl some control on the environment variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able use those commands. This makes the settings more consistent with src/Makefile.global.in, as the same default gets used for Make and MSVC builds. Each parameter can be changed in buildenv.pl, but as a default gets assigned after loading buldenv.pl, it is not possible to unset any of these, and using an empty value would not work with "||=" either. As some environments may not have a compatible command in their PATH (tar coming from MinGW is an issue, for one), this could break tests without an exit path to bypass any failing test. This commit changes things so as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before loading buildenv.pl, not after. This way, we keep the same amount of compatibility as a GNU build with the same defaults, and it becomes possible to unset any of those values. While on it, this adds some documentation about those three variables in the section dedicated to the TAP tests for MSVC. Per discussion with Andrew Dunstan. Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz Backpatch-through: 10 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f2e4bbf408cfb903530b86c7bb4ef10413a23d30 Modified Files -------------- doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++ src/tools/msvc/vcregress.pl | 14 +++++++------- 2 files changed, 41 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-12-15 01:41 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz> 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz> 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz> 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz> 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz> 2021-12-15 01:41 pgsql: Adjust behavior of some env settings for the TAP tests of MSVC Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox