pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL
@ 2021-12-22 06:38 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2021-12-22 06:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY

One code path related to this flavor of ALTER TABLE was checking that
the relation to detach has to be a normal table or a partitioned table,
which would fail if using the command with a different relation kind.

Views, sequences and materialized views cannot be part of a partition
tree, so these would cause the command to fail anyway, but the assertion
was triggered.  Foreign tables can be part of a partition tree, and
again the assertion would have failed.  The simplest solution is just to
remove this assertion, so as we get the same failure as the
non-concurrent code path.

While on it, add a regression test in postgres_fdw for the concurrent
partition detach of a foreign table, as per a suggestion from Alexander
Lakhin.

Issue introduced in 71f4c8c.

Reported-by: Alexander Lakhin
Author: Michael Paquier, Alexander Lakhin
Reviewed-by: Peter Eisentraut, Kyotaro Horiguchi
Discussion: https://postgr.es/m/17339-a9e09aaf38a3457a@postgresql.org
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2e577c94466fde77d24cd44dc47059cf9cf392a4

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 3 +++
contrib/postgres_fdw/sql/postgres_fdw.sql      | 3 +++
src/backend/commands/tablecmds.c               | 2 --
3 files changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL
@ 2021-12-22 06:38 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2021-12-22 06:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY

One code path related to this flavor of ALTER TABLE was checking that
the relation to detach has to be a normal table or a partitioned table,
which would fail if using the command with a different relation kind.

Views, sequences and materialized views cannot be part of a partition
tree, so these would cause the command to fail anyway, but the assertion
was triggered.  Foreign tables can be part of a partition tree, and
again the assertion would have failed.  The simplest solution is just to
remove this assertion, so as we get the same failure as the
non-concurrent code path.

While on it, add a regression test in postgres_fdw for the concurrent
partition detach of a foreign table, as per a suggestion from Alexander
Lakhin.

Issue introduced in 71f4c8c.

Reported-by: Alexander Lakhin
Author: Michael Paquier, Alexander Lakhin
Reviewed-by: Peter Eisentraut, Kyotaro Horiguchi
Discussion: https://postgr.es/m/17339-a9e09aaf38a3457a@postgresql.org
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8a22a40b2cfd1ea3218663153e5c6d7ebc68d2bf

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 3 +++
contrib/postgres_fdw/sql/postgres_fdw.sql      | 3 +++
src/backend/commands/tablecmds.c               | 2 --
3 files changed, 6 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-12-22 06:38 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 06:38 pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL Michael Paquier <michael@paquier.xyz>
2021-12-22 06:38 pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox