pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statemen
2+ messages / 1 participants
[nested] [flat]

* pgsql: Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statemen
@ 2021-12-30 12:25  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Daniel Gustafsson @ 2021-12-30 12:25 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statements"

The reverted commit attempted to fix SQL specification compliance for
the cases which 6aaaa76bb left.  This however broke existing behavior
which takes precedence over spec compliance so revert. The introduced
tests are left after the revert since the codepath isn't well covered.
Per bug report 17346. Backpatch down to 14 where it was introduced.

Reported-by: Andrew Bille <andrewbille@gmail.com>
Discussion: https://postgr.es/m/17346-f72b28bd1a341060@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e68570e388f08c2e36ce7d2a9564941b89db6549

Modified Files
--------------
src/backend/commands/user.c              | 11 -----------
src/backend/parser/gram.y                |  2 --
src/test/regress/expected/privileges.out |  2 --
3 files changed, 15 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statemen
@ 2021-12-30 12:26  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Daniel Gustafsson @ 2021-12-30 12:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statements"

The reverted commit attempted to fix SQL specification compliance for
the cases which 6aaaa76bb left.  This however broke existing behavior
which takes precedence over spec compliance so revert. The introduced
tests are left after the revert since the codepath isn't well covered.
Per bug report 17346. Backpatch down to 14 where it was introduced.

Reported-by: Andrew Bille <andrewbille@gmail.com>
Discussion: https://postgr.es/m/17346-f72b28bd1a341060@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cb4f1be43ad2c60ea80b07d3345d8a52ca9f763f

Modified Files
--------------
src/backend/commands/user.c              | 11 -----------
src/backend/parser/gram.y                |  2 --
src/test/regress/expected/privileges.out |  2 --
3 files changed, 15 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-12-30 12:26 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 12:25 pgsql: Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statemen Daniel Gustafsson <dgustafsson@postgresql.org>
2021-12-30 12:26 pgsql: Revert b2a459edf "Fix GRANTED BY support in REVOKE ROLE statemen Daniel Gustafsson <dgustafsson@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox