pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Clean up error message reported after \password encryption failu
3+ messages / 2 participants
[nested] [flat]

* pgsql: Clean up error message reported after \password encryption failu
@ 2022-01-11 17:03  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 3+ messages in thread

From: Tom Lane @ 2022-01-11 17:03 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up error message reported after \password encryption failure.

Experimenting with FIPS mode enabled, I saw

regression=# \password joe
Enter new password for user "joe":
Enter it again:
could not encrypt password: disabled for FIPS
out of memory

because PQencryptPasswordConn was still of the opinion that "out of
memory" is always appropriate to print.

Minor oversight in b69aba745.  Like that one, back-patch to v14.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9cb5518b7ff69ab3bbc422313c69d54696fe8472

Modified Files
--------------
src/interfaces/libpq/fe-auth.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Clean up error message reported after \password encryption failu
@ 2022-01-11 17:03  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-01-11 17:03 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up error message reported after \password encryption failure.

Experimenting with FIPS mode enabled, I saw

regression=# \password joe
Enter new password for user "joe":
Enter it again:
could not encrypt password: disabled for FIPS
out of memory

because PQencryptPasswordConn was still of the opinion that "out of
memory" is always appropriate to print.

Minor oversight in b69aba745.  Like that one, back-patch to v14.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ab27df2490e3a5dfb8ecb3de66818d16645ef3dd

Modified Files
--------------
src/interfaces/libpq/fe-auth.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Clean up error message reported after \password encryption failu
@ 2022-01-12 02:24  Michael Paquier <michael@paquier.xyz>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2022-01-12 02:24 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Jan 11, 2022 at 05:03:17PM +0000, Tom Lane wrote:
> Clean up error message reported after \password encryption failure.

Thanks!
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-01-12 02:24 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 17:03 pgsql: Clean up error message reported after \password encryption failu Tom Lane <tgl@sss.pgh.pa.us>
2022-01-12 02:24 ` Michael Paquier <michael@paquier.xyz>
2022-01-11 17:03 pgsql: Clean up error message reported after \password encryption failu Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox