pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Add Boolean node
2+ messages / 2 participants
[nested] [flat]

* pgsql: Add Boolean node
@ 2022-01-17 09:43 Peter Eisentraut <peter@eisentraut.org>
  2022-01-17 15:15 ` Re: pgsql: Add Boolean node Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 2+ messages in thread

From: Peter Eisentraut @ 2022-01-17 09:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add Boolean node

Before, SQL-level boolean constants were represented by a string with
a cast, and internal Boolean values in DDL commands were usually
represented by Integer nodes.  This takes the place of both of these
uses, making the intent clearer and having some amount of type safety.

Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/8c1a2e37-c68d-703c-5a83-7a6077f4f997@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/941460fcf731a32e6a90691508d5cfa3d1f8eeaf

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c             | 32 ++++----
src/backend/commands/define.c                   |  2 +
src/backend/commands/functioncmds.c             | 14 ++--
src/backend/commands/sequence.c                 |  4 +-
src/backend/commands/tsearchcmds.c              |  9 +++
src/backend/commands/user.c                     | 28 +++----
src/backend/nodes/copyfuncs.c                   | 16 ++++
src/backend/nodes/equalfuncs.c                  | 11 +++
src/backend/nodes/nodeFuncs.c                   |  1 +
src/backend/nodes/outfuncs.c                    |  8 ++
src/backend/nodes/read.c                        |  9 ++-
src/backend/nodes/value.c                       | 12 +++
src/backend/parser/gram.y                       | 99 +++++++++++++------------
src/backend/parser/parse_node.c                 |  8 ++
src/backend/replication/repl_gram.y             | 14 ++--
src/include/nodes/nodes.h                       |  1 +
src/include/nodes/parsenodes.h                  |  1 +
src/include/nodes/value.h                       |  8 ++
src/test/isolation/expected/ri-trigger.out      | 60 +++++++--------
src/test/regress/expected/create_function_3.out |  2 +-
20 files changed, 211 insertions(+), 128 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Add Boolean node
  2022-01-17 09:43 pgsql: Add Boolean node Peter Eisentraut <peter@eisentraut.org>
@ 2022-01-17 15:15 ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-01-17 15:15 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

Peter Eisentraut <peter@eisentraut.org> writes:
> Add Boolean node

FTR, there should have been a catversion bump here, since this
certainly broke stored views.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-01-17 15:15 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 09:43 pgsql: Add Boolean node Peter Eisentraut <peter@eisentraut.org>
2022-01-17 15:15 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox