pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix one-off bug causing missing commit timestamps for subtransac 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/919be95c6f8aeb954e328e0a0fc0fc48d78a7a46 Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/237d1f317240b60b3fff698f4e9b184d1db83a6e Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0ffe2975c37473981113fc461990c7533bbcf26d Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1c0452c48ca4e5fcdc56808a2f475bbf6b546b86 Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/84db5169d4715904b0bffa25509f3c77fcd52188 Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix one-off bug causing missing commit timestamps for subtransac @ 2022-01-21 05:55 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2022-01-21 05:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix one-off bug causing missing commit timestamps for subtransactions The logic in charge of writing commit timestamps (enabled with track_commit_timestamp) for subtransactions had a one-bug bug, where it would be possible that commit timestamps go missing for the last subtransaction committed. While on it, simplify a bit the iteration logic in the loop writing the commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom Lane, so as some variable initializations are not part of the loop itself. Issue introduced in 73c986a. Analyzed-by: Alex Kingsborough Author: Alex Kingsborough, Kyotaro Horiguchi Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com Backpatch-through: 10 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b5f634116e8f3e264cc06c053bd7b4e25a615665 Modified Files -------------- src/backend/access/transam/commit_ts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-01-21 05:55 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz> 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz> 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz> 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz> 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz> 2022-01-21 05:55 pgsql: Fix one-off bug causing missing commit timestamps for subtransac Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox