pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Correct type of front_pathkey to PathKey 6+ messages / 1 participants [nested] [flat]
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:10 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7b65862e2280eafca00566ee44af2c1bbb143e9d Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:11 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/72ac4d71b54fdac5efc9ecfc23663f26c20ddcf9 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:11 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4d8c4d2061f90db009ec834308e260fb5ca1e885 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:12 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/93854d5b1bf340858a46a9696320dac1065b9c32 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:12 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5e9fe25307711030ca7168b78a369e30e1980887 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Correct type of front_pathkey to PathKey @ 2022-01-23 03:13 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2022-01-23 03:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Correct type of front_pathkey to PathKey In sort_inner_and_outer we iterate a list of PathKey elements, but the variable is declared as (List *). This mistake is benign, because we only pass the pointer to lcons() and never dereference it. This exists since ~2004, but it's confusing. So fix and backpatch to all supported branches. Backpatch-through: 10 Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a3eb08b809a4b9e348efb0bae9c2834b71d53273 Modified Files -------------- src/backend/optimizer/path/joinpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-01-23 03:13 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-01-23 03:10 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org> 2022-01-23 03:11 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org> 2022-01-23 03:11 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org> 2022-01-23 03:12 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org> 2022-01-23 03:12 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org> 2022-01-23 03:13 pgsql: Correct type of front_pathkey to PathKey Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox