pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remember to reset yy_start state when firing up repl_scanner.l. 6+ messages / 1 participants [nested] [flat]
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3c06ec6d1412a6ebf05ee0566b5c05969f0b541f Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/daf658982889451e6cdb9763482a03656407ae3e Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/449a696236ff6d8a86b98ae6503aa51dc39a37b2 Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a8ce5c8d788823f9bb79ab5760a396bfe2116529 Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c94c6612da573d2789855b77a47da45a4a19cfbd Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remember to reset yy_start state when firing up repl_scanner.l. @ 2022-01-24 17:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-01-24 17:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remember to reset yy_start state when firing up repl_scanner.l. Without this, we get odd behavior when the previous cycle of lexing exited in a non-default exclusive state. Every other copy of this code is aware that it has to do BEGIN(INITIAL), but repl_scanner.l did not get that memo. The real-world impact of this is probably limited, since most replication clients would abandon their connection after getting a syntax error. Still, it's a bug. This mistake is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ef9706bbc8ce917a366e4640df8c603c9605817a Modified Files -------------- src/backend/replication/repl_scanner.l | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-01-24 17:10 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us> 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us> 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us> 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us> 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us> 2022-01-24 17:10 pgsql: Remember to reset yy_start state when firing up repl_scanner.l. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox