pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e26aa641e8a4fbd0a56f79119b0d8f62dbd4ddc

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d13a838e1c19df5358d250b8d469544d7ab3dfda

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9c7cf083f26e183e200395b3514061bb9d71cc7e

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f469f0678c3042b8bf96080ccf7cd0aa53468a2d

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/46bf1f2dc750de8e620d63f3dc2ad6f569886175

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
@ 2022-02-05 17:00 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-05 17:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dcfaa7c67e7b5fef0446a63d38dc66ef9035ef5f

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-02-05 17:00 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>
2022-02-05 17:00 pgsql: Test, don't just Assert, that mergejoin's inputs are in order. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox