pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove ppport.h's broken re-implementation of eval_pv().
6+ messages / 1 participants
[nested] [flat]

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e327291e4a96571c85b6a9b140e1a8116fb47ec6

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3a6e3a89022f39e0250b23635bcf5985940e6524

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ea3b99de07bd1c1757effc9664d0786cb21c963

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5c2a91e54cd083429dbb89113addf56bdac6a48

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1a8b6f055567b553376bb6b9e295379b613baeea

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove ppport.h's broken re-implementation of eval_pv().
@ 2022-02-09 00:27  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-02-09 00:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/eba0f095c780fad505a859ee6713123692affa30

Modified Files
--------------
src/pl/plperl/ppport.h | 8 ++++++++
1 file changed, 8 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-02-09 00:27 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>
2022-02-09 00:27 pgsql: Remove ppport.h's broken re-implementation of eval_pv(). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox