pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
6+ messages / 1 participants
[nested] [flat]

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1a027e6b7bdf06dc3bfe1e63a2493f13629cf44a

Modified Files
--------------
contrib/pgcrypto/px.c                       |  2 +-
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c |  4 +--
src/backend/access/transam/clog.c           |  5 +--
src/backend/access/transam/xact.c           |  5 +--
src/backend/nodes/copyfuncs.c               | 54 +++++++++++------------------
src/backend/storage/ipc/shm_mq.c            |  7 ++--
src/backend/utils/adt/numeric.c             |  8 +++++
src/backend/utils/time/snapmgr.c            | 10 +++---
src/fe_utils/print.c                        |  3 +-
10 files changed, 52 insertions(+), 48 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cfbe87bd6f644e2b9b172516d94b971ed94dfc89

Modified Files
--------------
contrib/pgcrypto/px.c             |  2 +-
src/backend/access/heap/heapam.c  |  2 +-
src/backend/access/transam/xact.c |  5 +++--
src/backend/nodes/copyfuncs.c     | 46 +++++++++++++++------------------------
src/backend/storage/ipc/shm_mq.c  |  7 ++++--
src/backend/utils/adt/numeric.c   |  8 +++++++
src/backend/utils/time/snapmgr.c  | 10 +++++----
src/backend/utils/time/tqual.c    |  4 ++--
src/fe_utils/print.c              |  3 ++-
9 files changed, 45 insertions(+), 42 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f2087e26ebf15fe9ac59d0b485e1a5e4a8493e07

Modified Files
--------------
contrib/pgcrypto/px.c             |  2 +-
src/backend/access/heap/heapam.c  |  2 +-
src/backend/access/transam/clog.c |  5 +++--
src/backend/access/transam/xact.c |  5 +++--
src/backend/nodes/copyfuncs.c     | 46 +++++++++++++++------------------------
src/backend/storage/ipc/shm_mq.c  |  7 ++++--
src/backend/utils/adt/numeric.c   |  8 +++++++
src/backend/utils/time/snapmgr.c  | 10 +++++----
src/backend/utils/time/tqual.c    |  4 ++--
src/fe_utils/print.c              |  3 ++-
10 files changed, 48 insertions(+), 44 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b0bc196e52e606fe0116fb63da20f57fb577745b

Modified Files
--------------
contrib/pgcrypto/px.c                       |  2 +-
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c |  4 +--
src/backend/access/transam/clog.c           |  5 +--
src/backend/access/transam/xact.c           |  5 +--
src/backend/nodes/copyfuncs.c               | 54 +++++++++++------------------
src/backend/storage/ipc/shm_mq.c            |  7 ++--
src/backend/utils/adt/numeric.c             |  8 +++++
src/backend/utils/time/snapmgr.c            | 10 +++---
src/fe_utils/print.c                        |  3 +-
10 files changed, 52 insertions(+), 48 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f727b6ea8f3b42496e21361ddc1af9d7e12582ad

Modified Files
--------------
contrib/pgcrypto/px.c                       |  2 +-
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c |  4 +--
src/backend/access/transam/clog.c           |  5 +--
src/backend/access/transam/xact.c           |  5 +--
src/backend/nodes/copyfuncs.c               | 54 +++++++++++------------------
src/backend/storage/ipc/shm_mq.c            |  7 ++--
src/backend/utils/adt/numeric.c             |  8 +++++
src/backend/utils/time/snapmgr.c            | 10 +++---
src/fe_utils/print.c                        |  3 +-
10 files changed, 52 insertions(+), 48 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch
@ 2022-03-03 23:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-03-03 23:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up assorted failures under clang's -fsanitize=undefined checks.

Most of these are cases where we could call memcpy() or other libc
functions with a NULL pointer and a zero count, which is forbidden
by POSIX even though every production version of libc allows it.
We've fixed such things before in a piecemeal way, but apparently
never made an effort to try to get them all.  I don't claim that
this patch does so either, but it gets every failure I observe in
check-world, using clang 12.0.1 on current RHEL8.

numeric.c has a different issue that the sanitizer doesn't like:
"ln(-1.0)" will compute log10(0) and then try to assign the
resulting -Inf to an integer variable.  We don't actually use the
result in such a case, so there's no live bug.

Back-patch to all supported branches, with the idea that we might
start running a buildfarm member that tests this case.  This includes
back-patching c1132aae3 (Check the size in COPY_POINTER_FIELD),
which previously silenced some of these issues in copyfuncs.c.

Discussion: https://postgr.es/m/CALNJ-vT9r0DSsAOw9OXVJFxLENoVS_68kJ5x0p44atoYH+H4dg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46ab07ffda9d6c8e63360ded2d4568aa160a7700

Modified Files
--------------
contrib/pgcrypto/px.c                       |  2 +-
src/backend/access/heap/heapam.c            |  2 +-
src/backend/access/heap/heapam_visibility.c |  4 ++--
src/backend/access/transam/clog.c           |  5 +++--
src/backend/access/transam/xact.c           |  5 +++--
src/backend/storage/ipc/shm_mq.c            |  7 +++++--
src/backend/utils/adt/numeric.c             |  8 ++++++++
src/backend/utils/time/snapmgr.c            | 10 ++++++----
src/fe_utils/print.c                        |  3 ++-
9 files changed, 31 insertions(+), 15 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-03-03 23:13 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>
2022-03-03 23:13 pgsql: Clean up assorted failures under clang's -fsanitize=undefined ch Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox