pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix race between DROP TABLESPACE and checkpointing.
6+ messages / 1 participants
[nested] [flat]
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:38 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/46d9bfb0a68f7b145199711d2fb5d37561c4a130
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/sync/sync.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:38 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/26e00793980996fada8d61181d45070ce9fee600
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/sync/sync.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:39 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/51e760e5a667e7fcc1660756d657121b778861bf
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/sync/sync.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:39 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c918f07dd47963ed4602636d5d9d1792da11515b
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/sync/sync.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:39 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ca522c60a5db8fe12179fd0a6bb4663b0c09c936
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/smgr/md.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix race between DROP TABLESPACE and checkpointing.
@ 2022-03-16 05:39 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2022-03-16 05:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix race between DROP TABLESPACE and checkpointing.
Commands like ALTER TABLE SET TABLESPACE may leave files for the next
checkpoint to clean up. If such files are not removed by the time DROP
TABLESPACE is called, we request a checkpoint so that they are deleted.
However, there is presently a window before checkpoint start where new
unlink requests won't be scheduled until the following checkpoint. This
means that the checkpoint forced by DROP TABLESPACE might not remove the
files we expect it to remove, and the following ERROR will be emitted:
ERROR: tablespace "mytblspc" is not empty
To fix, add a call to AbsorbSyncRequests() just before advancing the
unlink cycle counter. This ensures that any unlink requests forwarded
prior to checkpoint start (i.e., when ckpt_started is incremented) will
be processed by the current checkpoint. Since AbsorbSyncRequests()
performs memory allocations, it cannot be called within a critical
section, so we also need to move SyncPreCheckpoint() to before
CreateCheckPoint()'s critical section.
This is an old bug, so back-patch to all supported versions.
Author: Nathan Bossart <nathandbossart@gmail.com>
Reported-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220215235845.GA2665318%40nathanxps13
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fe197872cfe8d29b3134568df06b3fba2cdd4c18
Modified Files
--------------
src/backend/access/transam/xlog.c | 15 ++++++++-------
src/backend/storage/smgr/md.c | 14 +++++++++++++-
2 files changed, 21 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-03-16 05:39 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 05:38 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
2022-03-16 05:38 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
2022-03-16 05:39 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
2022-03-16 05:39 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
2022-03-16 05:39 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
2022-03-16 05:39 pgsql: Fix race between DROP TABLESPACE and checkpointing. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox