pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Add missing dependency of pg_dumpall to WIN32RES.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2d608c9607584a30ff718d2c9f211ef3c692a315

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd1951ba0820005efc801bc5a1bcb46e957feda1

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f183e23cc8a9107b6a8ddc7f16b97da926fddf94

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/097786fbbb58897fec12ed9bfff3940c77b5867b

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4553b960f3a3faf520bd0bb485e93fa355384c74

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Add missing dependency of pg_dumpall to WIN32RES.
@ 2022-03-22 15:29  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 6+ messages in thread

From: Andres Freund @ 2022-03-22 15:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add missing dependency of pg_dumpall to WIN32RES.

When cross-building to windows, or building with mingw on windows, the build
could fail with
  x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.

Reported-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/083031aa99d739f5e8ff26d90e488ed4ac14892e

Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-03-22 15:29 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>
2022-03-22 15:29 pgsql: Add missing dependency of pg_dumpall to WIN32RES. Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox