pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Use has_privs_for_roles for predefined role checks
2+ messages / 1 participants
[nested] [flat]

* pgsql: Use has_privs_for_roles for predefined role checks
@ 2022-03-28 19:11 Joe Conway <mail@joeconway.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Joe Conway @ 2022-03-28 19:11 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use has_privs_for_roles for predefined role checks

Generally if a role is granted membership to another role with NOINHERIT
they must use SET ROLE to access the privileges of that role, however
with predefined roles the membership and privilege is conflated. Fix that
by replacing is_member_of_role with has_privs_for_role for predefined
roles. Patch does not remove is_member_of_role from acl.h, but it does
add a warning not to use that function for privilege checking. Not
backpatched based on hackers list discussion.

Author: Joshua Brindle
Reviewed-by: Stephen Frost, Nathan Bossart, Joe Conway
Discussion: https://postgr.es/m/flat/CAGB+Vh4Zv_TvKt2tv3QNS6tUM_F_9icmuj0zjywwcgVi4PAhFA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6198420ad8a72e37f4fe4964616b17e0fd33b808

Modified Files
--------------
contrib/adminpack/adminpack.c                        |  2 +-
contrib/file_fdw/expected/file_fdw.out               |  2 +-
contrib/file_fdw/file_fdw.c                          |  8 ++++----
contrib/pg_stat_statements/pg_stat_statements.c      |  4 ++--
contrib/pgrowlocks/pgrowlocks.c                      |  2 +-
doc/src/sgml/adminpack.sgml                          |  6 +++---
doc/src/sgml/catalogs.sgml                           | 12 ++++++------
doc/src/sgml/func.sgml                               | 12 ++++++------
doc/src/sgml/monitoring.sgml                         |  2 +-
doc/src/sgml/pgbuffercache.sgml                      |  2 +-
doc/src/sgml/pgfreespacemap.sgml                     |  2 +-
doc/src/sgml/pgrowlocks.sgml                         |  2 +-
doc/src/sgml/pgstatstatements.sgml                   |  2 +-
doc/src/sgml/pgvisibility.sgml                       |  4 ++--
src/backend/commands/copy.c                          | 12 ++++++------
src/backend/replication/walreceiver.c                |  8 ++++----
src/backend/replication/walsender.c                  |  8 ++++----
src/backend/utils/adt/acl.c                          |  4 ++++
src/backend/utils/adt/dbsize.c                       |  8 ++++----
src/backend/utils/adt/genfile.c                      |  6 +++---
src/backend/utils/adt/pgstatfuncs.c                  |  2 +-
src/backend/utils/misc/guc.c                         | 20 ++++++++++----------
src/test/modules/unsafe_tests/expected/rolenames.out |  2 +-
23 files changed, 68 insertions(+), 64 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Use has_privs_for_roles for predefined role checks: round 2
@ 2022-04-02 17:25 Joe Conway <mail@joeconway.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Joe Conway @ 2022-04-02 17:25 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use has_privs_for_roles for predefined role checks: round 2

Similar to commit 6198420ad, replace is_member_of_role with
has_privs_for_role for predefined role access checks in recently
committed basebackup code. In passing fix a double-word error
in a nearby comment.

Discussion: https://postgr.es/m/flat/CAGB+Vh4Zv_TvKt2tv3QNS6tUM_F_9icmuj0zjywwcgVi4PAhFA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9752436f049430428464e22dcf837e9c6fa4e513

Modified Files
--------------
contrib/basebackup_to_shell/basebackup_to_shell.c | 4 ++--
doc/src/sgml/ref/pg_basebackup.sgml               | 2 +-
src/backend/replication/basebackup_server.c       | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-04-02 17:25 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 19:11 pgsql: Use has_privs_for_roles for predefined role checks Joe Conway <mail@joeconway.com>
2022-04-02 17:25 pgsql: Use has_privs_for_roles for predefined role checks: round 2 Joe Conway <mail@joeconway.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox