pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Print information about type of test and subdirectory before run
2+ messages / 2 participants
[nested] [flat]
* pgsql: Print information about type of test and subdirectory before run
@ 2022-03-31 18:21 Andres Freund <andres@anarazel.de>
2022-04-08 07:51 ` Re: pgsql: Print information about type of test and subdirectory before run Peter Eisentraut <peter.eisentraut@enterprisedb.com>
0 siblings, 1 reply; 2+ messages in thread
From: Andres Freund @ 2022-03-31 18:21 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Print information about type of test and subdirectory before running tests.
When testing check-world it's hard to know what the test the test failure
output belongs to. The tap test output is especially problematic, partially
due to our practice of reusing test names like 001_basic.pl.
This isn't a real issue on the buildfarm, which invokes tests separately, but
locally and for CI it's quite annoying.
To fix, the test target provisos in Makefile.global.in now output
echo "+++ (regress|isolation|tap) [install-]check in $(subdir) +++"
before running the tests.
Discussion: https://postgr.es/m/20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/28bdfa2adfc6afe4121614b500bfcb27b7c6b94c
Modified Files
--------------
src/Makefile.global.in | 7 +++++++
1 file changed, 7 insertions(+)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Print information about type of test and subdirectory before run
2022-03-31 18:21 pgsql: Print information about type of test and subdirectory before run Andres Freund <andres@anarazel.de>
@ 2022-04-08 07:51 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2022-04-08 07:51 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org
On 31.03.22 20:21, Andres Freund wrote:
> To fix, the test target provisos in Makefile.global.in now output
> echo "+++ (regress|isolation|tap) [install-]check in $(subdir) +++"
> before running the tests.
For external extension modules (PGXS), subdir is usually not set, so
this output looks a bit silly then. Perhaps this should be conditional
on subdir being set, something like
$(if $(subdir),echo ...)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-04-08 07:51 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 18:21 pgsql: Print information about type of test and subdirectory before run Andres Freund <andres@anarazel.de>
2022-04-08 07:51 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox