pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove race condition in 022_crash_temp_files.pl test.
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove race condition in 022_crash_temp_files.pl test.
@ 2022-04-06 00:44 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-04-06 00:44 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove race condition in 022_crash_temp_files.pl test.

It's possible for the query that "waits for restart" to complete a
successful iteration before the postmaster has noticed its SIGKILL'd
child and begun the restart cycle.  (This is a bit hard to believe
perhaps, but it's been seen at least twice in the buildfarm, mainly
on ancient platforms that likely have quirky schedulers.)

To provide a more secure interlock, wait for the other session
we're using to report that it's been forcibly shut down.

Patch by me, based on a suggestion from Andres Freund.
Back-patch to v14 where this test case came in.

Discussion: https://postgr.es/m/1801850.1649047827@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e37ad5fa4df2319e26a7e779607130feae1a5029

Modified Files
--------------
src/test/recovery/t/022_crash_temp_files.pl | 34 +++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove race condition in 022_crash_temp_files.pl test.
@ 2022-04-06 00:44 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-04-06 00:44 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove race condition in 022_crash_temp_files.pl test.

It's possible for the query that "waits for restart" to complete a
successful iteration before the postmaster has noticed its SIGKILL'd
child and begun the restart cycle.  (This is a bit hard to believe
perhaps, but it's been seen at least twice in the buildfarm, mainly
on ancient platforms that likely have quirky schedulers.)

To provide a more secure interlock, wait for the other session
we're using to report that it's been forcibly shut down.

Patch by me, based on a suggestion from Andres Freund.
Back-patch to v14 where this test case came in.

Discussion: https://postgr.es/m/1801850.1649047827@sss.pgh.pa.us

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9a7229948c70945ca6ef0b36adfe61b74f4fdaf5

Modified Files
--------------
src/test/recovery/t/022_crash_temp_files.pl | 34 ++++++++++++++++++++++++-----
1 file changed, 29 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-04-06 00:44 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 00:44 pgsql: Remove race condition in 022_crash_temp_files.pl test. Tom Lane <tgl@sss.pgh.pa.us>
2022-04-06 00:44 pgsql: Remove race condition in 022_crash_temp_files.pl test. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox