pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. 5+ messages / 1 participants [nested] [flat]
* pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. @ 2022-04-14 15:11 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Robert Haas @ 2022-04-14 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rethink the delay-checkpoint-end mechanism in the back-branches. The back-patch of commit bbace5697df12398e87ffd9879171c39d27f5b33 had the unfortunate effect of changing the layout of PGPROC in the back-branches, which could break extensions. This happened because it changed the delayChkpt from type bool to type int. So, change it back, and add a new bool delayChkptEnd field instead. The new field should fall within what used to be padding space within the struct, and so hopefully won't cause any extensions to break. Per report from Markus Wanner and discussion with Tom Lane and others. Patch originally by me, somewhat revised by Markus Wanner per a suggestion from Michael Paquier. A very similar patch was developed by Kyotaro Horiguchi, but I failed to see the email in which that was posted before writing one of my own. Discussion: http://postgr.es/m/CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com Discussion: http://postgr.es/m/20220406.164521.17171257901083417.horikyota.ntt@gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/10520f4346876aad4941797c2255a21bdac74739 Modified Files -------------- src/backend/access/transam/multixact.c | 6 +-- src/backend/access/transam/twophase.c | 15 +++--- src/backend/access/transam/xact.c | 6 +-- src/backend/access/transam/xlog.c | 10 ++-- src/backend/access/transam/xloginsert.c | 2 +- src/backend/catalog/storage.c | 6 +-- src/backend/storage/buffer/bufmgr.c | 6 +-- src/backend/storage/ipc/procarray.c | 96 +++++++++++++++++++++++++-------- src/include/storage/proc.h | 35 ++---------- src/include/storage/procarray.h | 7 ++- 10 files changed, 109 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. @ 2022-04-14 15:11 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Robert Haas @ 2022-04-14 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rethink the delay-checkpoint-end mechanism in the back-branches. The back-patch of commit bbace5697df12398e87ffd9879171c39d27f5b33 had the unfortunate effect of changing the layout of PGPROC in the back-branches, which could break extensions. This happened because it changed the delayChkpt from type bool to type int. So, change it back, and add a new bool delayChkptEnd field instead. The new field should fall within what used to be padding space within the struct, and so hopefully won't cause any extensions to break. Per report from Markus Wanner and discussion with Tom Lane and others. Patch originally by me, somewhat revised by Markus Wanner per a suggestion from Michael Paquier. A very similar patch was developed by Kyotaro Horiguchi, but I failed to see the email in which that was posted before writing one of my own. Discussion: http://postgr.es/m/CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com Discussion: http://postgr.es/m/20220406.164521.17171257901083417.horikyota.ntt@gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d18c913b786c5ea82f7372c88cf2055050e5176a Modified Files -------------- src/backend/access/transam/multixact.c | 6 +-- src/backend/access/transam/twophase.c | 15 +++--- src/backend/access/transam/xact.c | 6 +-- src/backend/access/transam/xlog.c | 10 ++-- src/backend/access/transam/xloginsert.c | 2 +- src/backend/catalog/storage.c | 6 +-- src/backend/storage/buffer/bufmgr.c | 6 +-- src/backend/storage/ipc/procarray.c | 96 +++++++++++++++++++++++++-------- src/include/storage/proc.h | 35 ++---------- src/include/storage/procarray.h | 7 ++- 10 files changed, 109 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. @ 2022-04-14 15:11 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Robert Haas @ 2022-04-14 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rethink the delay-checkpoint-end mechanism in the back-branches. The back-patch of commit bbace5697df12398e87ffd9879171c39d27f5b33 had the unfortunate effect of changing the layout of PGPROC in the back-branches, which could break extensions. This happened because it changed the delayChkpt from type bool to type int. So, change it back, and add a new bool delayChkptEnd field instead. The new field should fall within what used to be padding space within the struct, and so hopefully won't cause any extensions to break. Per report from Markus Wanner and discussion with Tom Lane and others. Patch originally by me, somewhat revised by Markus Wanner per a suggestion from Michael Paquier. A very similar patch was developed by Kyotaro Horiguchi, but I failed to see the email in which that was posted before writing one of my own. Discussion: http://postgr.es/m/CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com Discussion: http://postgr.es/m/20220406.164521.17171257901083417.horikyota.ntt@gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/68e605b9ef37e9b3e96b97f71857efabd95d5321 Modified Files -------------- src/backend/access/transam/multixact.c | 6 +-- src/backend/access/transam/twophase.c | 15 +++--- src/backend/access/transam/xact.c | 6 +-- src/backend/access/transam/xlog.c | 10 ++-- src/backend/access/transam/xloginsert.c | 2 +- src/backend/catalog/storage.c | 6 +-- src/backend/storage/buffer/bufmgr.c | 6 +-- src/backend/storage/ipc/procarray.c | 96 +++++++++++++++++++++++++-------- src/include/storage/proc.h | 40 ++++---------- src/include/storage/procarray.h | 7 ++- 10 files changed, 114 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. @ 2022-04-14 15:11 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Robert Haas @ 2022-04-14 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rethink the delay-checkpoint-end mechanism in the back-branches. The back-patch of commit bbace5697df12398e87ffd9879171c39d27f5b33 had the unfortunate effect of changing the layout of PGPROC in the back-branches, which could break extensions. This happened because it changed the delayChkpt from type bool to type int. So, change it back, and add a new bool delayChkptEnd field instead. The new field should fall within what used to be padding space within the struct, and so hopefully won't cause any extensions to break. Per report from Markus Wanner and discussion with Tom Lane and others. Patch originally by me, somewhat revised by Markus Wanner per a suggestion from Michael Paquier. A very similar patch was developed by Kyotaro Horiguchi, but I failed to see the email in which that was posted before writing one of my own. Discussion: http://postgr.es/m/CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com Discussion: http://postgr.es/m/20220406.164521.17171257901083417.horikyota.ntt@gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6270ee4450404225daad44b53d4a067026f97162 Modified Files -------------- src/backend/access/transam/multixact.c | 6 +-- src/backend/access/transam/twophase.c | 15 +++--- src/backend/access/transam/xact.c | 6 +-- src/backend/access/transam/xlog.c | 10 ++-- src/backend/access/transam/xloginsert.c | 2 +- src/backend/catalog/storage.c | 6 +-- src/backend/storage/buffer/bufmgr.c | 6 +-- src/backend/storage/ipc/procarray.c | 96 +++++++++++++++++++++++++-------- src/include/storage/proc.h | 40 ++++---------- src/include/storage/procarray.h | 7 ++- 10 files changed, 114 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. @ 2022-04-14 15:11 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Robert Haas @ 2022-04-14 15:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rethink the delay-checkpoint-end mechanism in the back-branches. The back-patch of commit bbace5697df12398e87ffd9879171c39d27f5b33 had the unfortunate effect of changing the layout of PGPROC in the back-branches, which could break extensions. This happened because it changed the delayChkpt from type bool to type int. So, change it back, and add a new bool delayChkptEnd field instead. The new field should fall within what used to be padding space within the struct, and so hopefully won't cause any extensions to break. Per report from Markus Wanner and discussion with Tom Lane and others. Patch originally by me, somewhat revised by Markus Wanner per a suggestion from Michael Paquier. A very similar patch was developed by Kyotaro Horiguchi, but I failed to see the email in which that was posted before writing one of my own. Discussion: http://postgr.es/m/CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com Discussion: http://postgr.es/m/20220406.164521.17171257901083417.horikyota.ntt@gmail.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/48b398943b78a42c61771a1210c70ffa0b017164 Modified Files -------------- src/backend/access/transam/multixact.c | 6 +-- src/backend/access/transam/twophase.c | 15 +++--- src/backend/access/transam/xact.c | 6 +-- src/backend/access/transam/xlog.c | 10 ++-- src/backend/access/transam/xloginsert.c | 2 +- src/backend/catalog/storage.c | 6 +-- src/backend/storage/buffer/bufmgr.c | 6 +-- src/backend/storage/ipc/procarray.c | 96 +++++++++++++++++++++++++-------- src/include/storage/proc.h | 40 ++++---------- src/include/storage/procarray.h | 7 ++- 10 files changed, 114 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-04-14 15:11 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-04-14 15:11 pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. Robert Haas <rhaas@postgresql.org> 2022-04-14 15:11 pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. Robert Haas <rhaas@postgresql.org> 2022-04-14 15:11 pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. Robert Haas <rhaas@postgresql.org> 2022-04-14 15:11 pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. Robert Haas <rhaas@postgresql.org> 2022-04-14 15:11 pgsql: Rethink the delay-checkpoint-end mechanism in the back-branches. Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox