pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: postgres_fdw: Disable batch insert when BEFORE ROW INSERT trigge 2+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Disable batch insert when BEFORE ROW INSERT trigge @ 2022-04-21 06:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Etsuro Fujita @ 2022-04-21 06:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Disable batch insert when BEFORE ROW INSERT triggers exist. Previously, we allowed this, but such triggers might query the table to insert into and act differently if the tuples that have already been processed and prepared for insertion are not there, so disable it in such cases. Back-patch to v14 where batch insert was added. Discussion: https://postgr.es/m/CAPmGK16_uPqsmgK0-LpLSUk54_BoK13bPrhxhfjSoSTVz414hA%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/89d349b0a0239504325e5f63755f3bc1e1742478 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 28 ++++++++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 17 ++++++++++++---- contrib/postgres_fdw/sql/postgres_fdw.sql | 12 +++++++++++ 3 files changed, 53 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: postgres_fdw: Disable batch insert when BEFORE ROW INSERT trigge @ 2022-04-21 06:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Etsuro Fujita @ 2022-04-21 06:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Disable batch insert when BEFORE ROW INSERT triggers exist. Previously, we allowed this, but such triggers might query the table to insert into and act differently if the tuples that have already been processed and prepared for insertion are not there, so disable it in such cases. Back-patch to v14 where batch insert was added. Discussion: https://postgr.es/m/CAPmGK16_uPqsmgK0-LpLSUk54_BoK13bPrhxhfjSoSTVz414hA%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4eea2202beadbba67638bb129149abe5650aaaf6 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 28 ++++++++++++++++++++++++++ contrib/postgres_fdw/postgres_fdw.c | 17 ++++++++++++---- contrib/postgres_fdw/sql/postgres_fdw.sql | 12 +++++++++++ 3 files changed, 53 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-04-21 06:39 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-04-21 06:39 pgsql: postgres_fdw: Disable batch insert when BEFORE ROW INSERT trigge Etsuro Fujita <efujita@postgresql.org> 2022-04-21 06:39 pgsql: postgres_fdw: Disable batch insert when BEFORE ROW INSERT trigge Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox