pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove some recently-added pg_dump test cases.
4+ messages / 3 participants
[nested] [flat]

* pgsql: Remove some recently-added pg_dump test cases.
@ 2022-04-22 20:20 Robert Haas <rhaas@postgresql.org>
  2022-04-22 23:08 ` Re: pgsql: Remove some recently-added pg_dump test cases. Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Robert Haas @ 2022-04-22 20:20 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove some recently-added pg_dump test cases.

Commit d2d35479796c3510e249d6fc72adbd5df918efbf included a pretty
extensive set of test cases, and some of them don't work on all
of our Windows machines. This happens because IPC::Run expands
its arguments as shell globs on a few machines, but doesn't on most
of the buildfarm. It might be good to fix that problem systematically
somehow, but in the meantime, there are enough test cases for this
commit that it seems OK to just remove the ones that are failing.

Discussion: http://postgr.es/m/3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net
Discussion: http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a66e722cc1180cd7a2046fb552195a7d7703a592

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 30 ------------------------------
1 file changed, 30 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Remove some recently-added pg_dump test cases.
  2022-04-22 20:20 pgsql: Remove some recently-added pg_dump test cases. Robert Haas <rhaas@postgresql.org>
@ 2022-04-22 23:08 ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-25 13:31   ` Re: pgsql: Remove some recently-added pg_dump test cases. Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Tom Lane @ 2022-04-22 23:08 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org

Robert Haas <rhaas@postgresql.org> writes:
> Remove some recently-added pg_dump test cases.

Um ... you needed to do that in v14, too.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Remove some recently-added pg_dump test cases.
  2022-04-22 20:20 pgsql: Remove some recently-added pg_dump test cases. Robert Haas <rhaas@postgresql.org>
  2022-04-22 23:08 ` Re: pgsql: Remove some recently-added pg_dump test cases. Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-04-25 13:31   ` Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Robert Haas @ 2022-04-25 13:31 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>

On Fri, Apr 22, 2022 at 7:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <rhaas@postgresql.org> writes:
> > Remove some recently-added pg_dump test cases.
>
> Um ... you needed to do that in v14, too.

Sorry, Tom. Done now.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Remove some recently-added pg_dump test cases.
@ 2022-04-25 13:31 Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Robert Haas @ 2022-04-25 13:31 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove some recently-added pg_dump test cases.

Commit d2d35479796c3510e249d6fc72adbd5df918efbf included a pretty
extensive set of test cases, and some of them don't work on all
of our Windows machines. This happens because IPC::Run expands
its arguments as shell globs on a few machines, but doesn't on most
of the buildfarm. It might be good to fix that problem systematically
somehow, but in the meantime, there are enough test cases for this
commit that it seems OK to just remove the ones that are failing.

Discussion: http://postgr.es/m/3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net
Discussion: http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/75a006beef6c502a16bc4e1c0dc4d67d2cd5de9c

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 34 ++--------------------------------
1 file changed, 2 insertions(+), 32 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-04-25 13:31 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 20:20 pgsql: Remove some recently-added pg_dump test cases. Robert Haas <rhaas@postgresql.org>
2022-04-22 23:08 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-04-25 13:31   ` Robert Haas <robertmhaas@gmail.com>
2022-04-25 13:31 pgsql: Remove some recently-added pg_dump test cases. Robert Haas <rhaas@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox