pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Ensure ParseTzFile() closes the input file after failing.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/16c80e7d0cdad933103968aec7cd024bca5274c0

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c47a558528dd79fe76c698cde7e23f38610b05ed

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c73748b68a0e5f80d9014af748b194f728a074d3

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a3faebd6a58aaff0d6521428831041d517db62fe

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae758e603d5c5251cec40b81162aef1a897ca130

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Ensure ParseTzFile() closes the input file after failing.
@ 2022-05-31 18:47 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-31 18:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Ensure ParseTzFile() closes the input file after failing.

We hadn't noticed this because (a) few people feed invalid
timezone abbreviation files to the server, and (b) in typical
scenarios guc.c would throw ereport(ERROR) and then transaction
abort handling would silently clean up the leaked file reference.
However, it was possible to observe file leakage warnings if one
breaks an already-active abbreviation file, because guc.c does
not throw ERROR when loading supposedly-validated settings during
session start or SIGHUP processing.

Report and fix by Kyotaro Horiguchi (cosmetic adjustments by me)

Discussion: https://postgr.es/m/20220530.173740.748502979257582392.horikyota.ntt@gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2114910cae6ae3c623cd9b02ef79270cd5b0134e

Modified Files
--------------
src/backend/utils/misc/tzparser.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-05-31 18:47 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>
2022-05-31 18:47 pgsql: Ensure ParseTzFile() closes the input file after failing. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox