pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Un-break whole-row Vars referencing domain-over-composite types. 5+ messages / 1 participants [nested] [flat]
* pgsql: Un-break whole-row Vars referencing domain-over-composite types. @ 2022-06-10 14:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-06-10 14:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1218780ccebace6a4c4d5872d7b158aa36e6882e Modified Files -------------- src/backend/executor/execExprInterp.c | 6 +++++- src/test/regress/expected/domain.out | 23 +++++++++++++++++++++++ src/test/regress/sql/domain.sql | 9 +++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Un-break whole-row Vars referencing domain-over-composite types. @ 2022-06-10 14:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-06-10 14:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/77c1d92cbac15f3c9c02f9a5b1ef551842659de6 Modified Files -------------- src/backend/executor/execExprInterp.c | 6 +++++- src/test/regress/expected/domain.out | 23 +++++++++++++++++++++++ src/test/regress/sql/domain.sql | 9 +++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Un-break whole-row Vars referencing domain-over-composite types. @ 2022-06-10 14:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-06-10 14:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/254cd7f31f60f02de0548c8dcdc2c402c0cf02d8 Modified Files -------------- src/backend/executor/execExprInterp.c | 6 +++++- src/test/regress/expected/domain.out | 23 +++++++++++++++++++++++ src/test/regress/sql/domain.sql | 9 +++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Un-break whole-row Vars referencing domain-over-composite types. @ 2022-06-10 14:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-06-10 14:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d3ef5c3ef454ccd4a14b64e577777179a91c1641 Modified Files -------------- src/backend/executor/execExprInterp.c | 6 +++++- src/test/regress/expected/domain.out | 23 +++++++++++++++++++++++ src/test/regress/sql/domain.sql | 9 +++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Un-break whole-row Vars referencing domain-over-composite types. @ 2022-06-10 14:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-06-10 14:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/199aac8b2f74dcc19cf88ed7072617d753d9506c Modified Files -------------- src/backend/executor/execExprInterp.c | 6 +++++- src/test/regress/expected/domain.out | 23 +++++++++++++++++++++++ src/test/regress/sql/domain.sql | 9 +++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-06-10 14:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-06-10 14:36 pgsql: Un-break whole-row Vars referencing domain-over-composite types. Tom Lane <tgl@sss.pgh.pa.us> 2022-06-10 14:36 pgsql: Un-break whole-row Vars referencing domain-over-composite types. Tom Lane <tgl@sss.pgh.pa.us> 2022-06-10 14:36 pgsql: Un-break whole-row Vars referencing domain-over-composite types. Tom Lane <tgl@sss.pgh.pa.us> 2022-06-10 14:36 pgsql: Un-break whole-row Vars referencing domain-over-composite types. Tom Lane <tgl@sss.pgh.pa.us> 2022-06-10 14:36 pgsql: Un-break whole-row Vars referencing domain-over-composite types. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox