pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ac0e2d387a044faed310cbfe2fae78ecb0f6a4b6 Modified Files -------------- src/backend/replication/logical/relation.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3238b5c330bc384441473dd2859845c27d9ade2f Modified Files -------------- src/backend/replication/logical/relation.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3a6ef0cdf31191309ec586b04034f6dcd2542bcc Modified Files -------------- src/backend/replication/logical/relation.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9e0d9a24ef88fa6bbca8d28cc7af9e3cde7b4886 Modified Files -------------- src/backend/replication/logical/relation.c | 7 +++++++ 1 file changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ed2a7a6bf67d1b34e113b1b88855c85b6a39377d Modified Files -------------- src/backend/replication/logical/relation.c | 7 +++++++ 1 file changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. @ 2022-06-23 04:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Amit Kapila @ 2022-06-23 04:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d873b5a5a34069a316df77285b231b792aee1349 Modified Files -------------- src/backend/replication/logical/relation.c | 7 +++++++ 1 file changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-06-23 04:03 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org> 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org> 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org> 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org> 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org> 2022-06-23 04:03 pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox