pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use a short socket directory path in pg_upgrade testing. 2+ messages / 1 participants [nested] [flat]
* pgsql: Use a short socket directory path in pg_upgrade testing. @ 2022-07-04 01:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-04 01:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use a short socket directory path in pg_upgrade testing. Several buildfarm members are failing the pg_upgrade test in REL_15_STABLE, though the identical test is fine in HEAD. On thorntail it's possible to see that the problem is an overlength socket path name, and I bet the same is true on the others. The normally-started postmasters used in the test are already set up with short socket directory paths, but we neglected to tell pg_upgrade itself to do likewise when starting child postmasters, and indeed it seems to be explicitly selecting the test directory instead. Back-patch to v15 where the current test script was introduced. (The previous script might have the same issue, because I don't see any use of -s/--socketdir in it either; but we've had no complaints, so leave it alone for now.) Discussion: https://postgr.es/m/1410025.1656890531@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/255625df1d3a9823c891d585fbf5c3bb913182eb Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Use a short socket directory path in pg_upgrade testing. @ 2022-07-04 01:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-04 01:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use a short socket directory path in pg_upgrade testing. Several buildfarm members are failing the pg_upgrade test in REL_15_STABLE, though the identical test is fine in HEAD. On thorntail it's possible to see that the problem is an overlength socket path name, and I bet the same is true on the others. The normally-started postmasters used in the test are already set up with short socket directory paths, but we neglected to tell pg_upgrade itself to do likewise when starting child postmasters, and indeed it seems to be explicitly selecting the test directory instead. Back-patch to v15 where the current test script was introduced. (The previous script might have the same issue, because I don't see any use of -s/--socketdir in it either; but we've had no complaints, so leave it alone for now.) Discussion: https://postgr.es/m/1410025.1656890531@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5c1d80ea7797dc4a8e2cdc7e8e62edff50238abe Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-04 01:38 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-04 01:38 pgsql: Use a short socket directory path in pg_upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2022-07-04 01:38 pgsql: Use a short socket directory path in pg_upgrade testing. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox