pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix wrong field order in _readMergeWhenClause().
2+ messages / 1 participants
[nested] [flat]

* pgsql: Fix wrong field order in _readMergeWhenClause().
@ 2022-07-06 21:26  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-07-06 21:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix wrong field order in _readMergeWhenClause().

We hadn't noticed this because it's dead code: there is no
situation where we read raw parse trees from text format.
So maybe the right fix is to remove the function altogether,
but I'll forbear for now; it's not the only dead code in
readfuncs.c, I think.

Noted while comparing existing code to the results of
Peter's auto-generation script.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55b8ac81723c45dca95d4ad4892a1ee28db37c23

Modified Files
--------------
src/backend/nodes/readfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix wrong field order in _readMergeWhenClause().
@ 2022-07-06 21:26  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-07-06 21:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix wrong field order in _readMergeWhenClause().

We hadn't noticed this because it's dead code: there is no
situation where we read raw parse trees from text format.
So maybe the right fix is to remove the function altogether,
but I'll forbear for now; it's not the only dead code in
readfuncs.c, I think.

Noted while comparing existing code to the results of
Peter's auto-generation script.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dcffdc53496b47ece19bdf84a24997c4088c584d

Modified Files
--------------
src/backend/nodes/readfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-07-06 21:26 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 21:26 pgsql: Fix wrong field order in _readMergeWhenClause(). Tom Lane <tgl@sss.pgh.pa.us>
2022-07-06 21:26 pgsql: Fix wrong field order in _readMergeWhenClause(). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox