pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix lock assertions in dshash.c. 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:46 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/eed959a457ea0ffb042f4881e23358ba145d148c Modified Files -------------- src/backend/lib/dshash.c | 44 +++++++++------------------------------ src/backend/storage/lmgr/lwlock.c | 26 +++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 37 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:46 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/53df1e28d2f7554ab23292414ce3200f732ee1c1 Modified Files -------------- src/backend/lib/dshash.c | 44 +++++++++------------------------------ src/backend/storage/lmgr/lwlock.c | 26 +++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 37 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:47 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5e7608e81ebb2a9e2a72ab771eba3c620c0b42a6 Modified Files -------------- src/backend/lib/dshash.c | 35 +++++++++-------------------------- src/backend/storage/lmgr/lwlock.c | 26 ++++++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 36 insertions(+), 26 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:47 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7cdd0c2d7cdf08a4f8dfd8678a7b244c942e64e4 Modified Files -------------- src/backend/lib/dshash.c | 35 +++++++++-------------------------- src/backend/storage/lmgr/lwlock.c | 26 ++++++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 36 insertions(+), 26 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:47 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4f88dbac22a845a33c758554e25ca0ee7e9dedac Modified Files -------------- src/backend/lib/dshash.c | 37 ++++++++++--------------------------- src/backend/storage/lmgr/lwlock.c | 26 ++++++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 37 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lock assertions in dshash.c. @ 2022-07-11 04:47 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Thomas Munro @ 2022-07-11 04:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock assertions in dshash.c. dshash.c previously maintained flags to be able to assert that you didn't hold any partition lock. These flags could get out of sync with reality in error scenarios. Get rid of all that, and make assertions about the locks themselves instead. Since LWLockHeldByMe() loops internally, we don't want to put that inside another loop over all partition locks. Introduce a new debugging-only interface LWLockAnyHeldByMe() to avoid that. This problem was noted by Tom and Andres while reviewing changes to support the new shared memory stats system, and later showed up in reality while working on commit 389869af. Back-patch to 11, where dshash.c arrived. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Reviewed-by: Zhihong Yu <zyu@yugabyte.com> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20220311012712.botrpsikaufzteyt@alap3.anarazel.de Discussion: https://postgr.es/m/CA%2BhUKGJ31Wce6HJ7xnVTKWjFUWQZPBngxfJVx4q0E98pDr3kAw%40mail.gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cd26139a305658afedd8931359ff9aadfe4b973b Modified Files -------------- src/backend/lib/dshash.c | 37 ++++++++++--------------------------- src/backend/storage/lmgr/lwlock.c | 26 ++++++++++++++++++++++++++ src/include/storage/lwlock.h | 1 + 3 files changed, 37 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-07-11 04:47 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-11 04:46 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org> 2022-07-11 04:46 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org> 2022-07-11 04:47 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org> 2022-07-11 04:47 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org> 2022-07-11 04:47 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org> 2022-07-11 04:47 pgsql: Fix lock assertions in dshash.c. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox