pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix assertion failure and segmentation fault in backup code. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:57 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b24b2be119c4cccceae838b62a3519a6d70b9476 Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:58 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0829cc43ed69252184f90161b4940444d8b48574 Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:58 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/be2e842c8a79d98a3fa03eeaf9329bf1f51a9704 Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:58 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/162ade612f1543389bd105fba82ea7e60c5b82c9 Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:58 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f0eb83f81447e9ada090bcc76b3af07c07067468 Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:59 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/80c3ea918526378b00b7c90918e7f980c2799e1c Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix assertion failure and segmentation fault in backup code. @ 2022-07-20 00:59 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2022-07-20 00:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion failure and segmentation fault in backup code. When a non-exclusive backup is canceled, do_pg_abort_backup() is called and resets some variables set by pg_backup_start (pg_start_backup in v14 or before). But previously it forgot to reset the session state indicating whether a non-exclusive backup is in progress or not in this session. This issue could cause an assertion failure when the session running BASE_BACKUP is terminated after it executed pg_backup_start and pg_backup_stop (pg_stop_backup in v14 or before). Also it could cause a segmentation fault when pg_backup_stop is called after BASE_BACKUP in the same session is canceled. This commit fixes the issue by making do_pg_abort_backup reset that session state. Back-patch to all supported branches. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/3374718f-9fbf-a950-6d66-d973e027f44c@oss.nttdata.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2497d2b770916f802353f3bf5e03d42c4c98d3cf Modified Files -------------- src/backend/access/transam/xlog.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2022-07-20 00:59 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-20 00:57 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:58 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:58 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:58 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:58 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:59 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org> 2022-07-20 00:59 pgsql: Fix assertion failure and segmentation fault in backup code. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox