pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove test_oat_hooks.c's nodetag_to_string(). 2+ messages / 1 participants [nested] [flat]
* pgsql: Remove test_oat_hooks.c's nodetag_to_string(). @ 2022-07-31 20:59 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-31 20:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove test_oat_hooks.c's nodetag_to_string(). In the short time this function has existed, it's already proven to be a nontrivial maintenance burden, since it has to be updated whenever a node tag is added or removed. Although in principle we could now automate that, I see little justification for having such functionality here at all. The function is only being applied to utility statements, for which we already have infrastructure for obtaining string names. Moreover, that infrastructure produces already-familiar-to-users names, unlike nodetag_to_string(). So, remove this function and use the existing infrastructure instead. That saves over a thousand lines of largely-unreachable code. Back-patch to v15 where this code came in. Although it seems unlikely that v15's nodetag list will change anymore, we might as well keep the two branches looking and acting alike; otherwise back-patching any test-results changes in this area will be painful. Discussion: https://postgr.es/m/843818.1659218928@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6e37312a2a595b7f75e1190b2d15e88d54b366a7 Modified Files -------------- .../test_oat_hooks/expected/test_oat_hooks.out | 160 +-- src/test/modules/test_oat_hooks/test_oat_hooks.c | 1328 +------------------- 2 files changed, 81 insertions(+), 1407 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove test_oat_hooks.c's nodetag_to_string(). @ 2022-07-31 20:59 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-31 20:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove test_oat_hooks.c's nodetag_to_string(). In the short time this function has existed, it's already proven to be a nontrivial maintenance burden, since it has to be updated whenever a node tag is added or removed. Although in principle we could now automate that, I see little justification for having such functionality here at all. The function is only being applied to utility statements, for which we already have infrastructure for obtaining string names. Moreover, that infrastructure produces already-familiar-to-users names, unlike nodetag_to_string(). So, remove this function and use the existing infrastructure instead. That saves over a thousand lines of largely-unreachable code. Back-patch to v15 where this code came in. Although it seems unlikely that v15's nodetag list will change anymore, we might as well keep the two branches looking and acting alike; otherwise back-patching any test-results changes in this area will be painful. Discussion: https://postgr.es/m/843818.1659218928@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3451a57f77848d69ced234b7989cc0e351383cd2 Modified Files -------------- .../test_oat_hooks/expected/test_oat_hooks.out | 168 +-- src/test/modules/test_oat_hooks/test_oat_hooks.c | 1319 +------------------- 2 files changed, 85 insertions(+), 1402 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-31 20:59 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-31 20:59 pgsql: Remove test_oat_hooks.c's nodetag_to_string(). Tom Lane <tgl@sss.pgh.pa.us> 2022-07-31 20:59 pgsql: Remove test_oat_hooks.c's nodetag_to_string(). Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox