pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap @ 2022-08-05 19:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-08-05 19:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix handling of bare boolean expressions in mcv_get_match_bitmap. Since v14, the extended stats machinery will try to estimate for otherwise-unsupported boolean expressions if they match an expression available from an extended stats object. mcv.c did not get the memo about this, and would spit up with "unknown clause type". Fortunately the case is easy to handle, since we can expect the expression yields boolean. While here, replace some not-terribly-on-point assertions with simpler runtime tests for lookup failure. That seems appropriate so that we get an elog not a crash if we somehow get to the new it-should-be-a-bool-expression code with a subexpression that doesn't match any stats column. Per report from Danny Shemesh. Thanks to Justin Pryzby for preliminary investigation. Discussion: https://postgr.es/m/CAFZC=QqD6=27wQPOW1pbRa98KPyuyn+7cL_Ay_Ck-roZV84vHg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e33ae53ddec80c15d297a31713212c05ea7341db Modified Files -------------- src/backend/statistics/mcv.c | 51 ++++++++++++++++++++++----------- src/test/regress/expected/stats_ext.out | 19 ++++++++---- src/test/regress/sql/stats_ext.sql | 17 +++++++---- 3 files changed, 60 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap @ 2022-08-05 19:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-08-05 19:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix handling of bare boolean expressions in mcv_get_match_bitmap. Since v14, the extended stats machinery will try to estimate for otherwise-unsupported boolean expressions if they match an expression available from an extended stats object. mcv.c did not get the memo about this, and would spit up with "unknown clause type". Fortunately the case is easy to handle, since we can expect the expression yields boolean. While here, replace some not-terribly-on-point assertions with simpler runtime tests for lookup failure. That seems appropriate so that we get an elog not a crash if we somehow get to the new it-should-be-a-bool-expression code with a subexpression that doesn't match any stats column. Per report from Danny Shemesh. Thanks to Justin Pryzby for preliminary investigation. Discussion: https://postgr.es/m/CAFZC=QqD6=27wQPOW1pbRa98KPyuyn+7cL_Ay_Ck-roZV84vHg@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/43f76fb1944ea5219856819535e2386362ccad49 Modified Files -------------- src/backend/statistics/mcv.c | 51 ++++++++++++++++++++++----------- src/test/regress/expected/stats_ext.out | 19 ++++++++---- src/test/regress/sql/stats_ext.sql | 17 +++++++---- 3 files changed, 60 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap @ 2022-08-05 19:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2022-08-05 19:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix handling of bare boolean expressions in mcv_get_match_bitmap. Since v14, the extended stats machinery will try to estimate for otherwise-unsupported boolean expressions if they match an expression available from an extended stats object. mcv.c did not get the memo about this, and would spit up with "unknown clause type". Fortunately the case is easy to handle, since we can expect the expression yields boolean. While here, replace some not-terribly-on-point assertions with simpler runtime tests for lookup failure. That seems appropriate so that we get an elog not a crash if we somehow get to the new it-should-be-a-bool-expression code with a subexpression that doesn't match any stats column. Per report from Danny Shemesh. Thanks to Justin Pryzby for preliminary investigation. Discussion: https://postgr.es/m/CAFZC=QqD6=27wQPOW1pbRa98KPyuyn+7cL_Ay_Ck-roZV84vHg@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3fe2fc6bbdb251c78a88cdd41e400014be76f80e Modified Files -------------- src/backend/statistics/mcv.c | 51 ++++++++++++++++++++++----------- src/test/regress/expected/stats_ext.out | 19 ++++++++---- src/test/regress/sql/stats_ext.sql | 17 +++++++---- 3 files changed, 60 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-08-05 19:00 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-05 19:00 pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap Tom Lane <tgl@sss.pgh.pa.us> 2022-08-05 19:00 pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap Tom Lane <tgl@sss.pgh.pa.us> 2022-08-05 19:00 pgsql: Fix handling of bare boolean expressions in mcv_get_match_bitmap Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox