pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Replace pgwin32_is_junction() with lstat(). 3+ messages / 2 participants [nested] [flat]
* pgsql: Replace pgwin32_is_junction() with lstat(). @ 2022-08-06 00:52 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Thomas Munro @ 2022-08-06 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Replace pgwin32_is_junction() with lstat(). Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and unlink() can unlink them, there is no need for conditional code for Windows in a few places. That was expressed by testing for WIN32 or S_ISLNK, which we can now constant-fold. The coding around pgwin32_is_junction() was a bit suspect anyway, as we never checked for errors, and we also know that errors can be spuriously reported because of transient sharing violations on this OS. The lstat()-based code has handling for that. This also reverts 4fc6b6ee on master only. That was done because lstat() didn't previously work for symlinks (junction points), but now it does. Tested-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5fc88c5d53e43fa7dcea93499d230a0bf70f4f77 Modified Files -------------- src/backend/commands/tablespace.c | 7 +------ src/backend/replication/basebackup.c | 12 +----------- src/backend/storage/file/fd.c | 5 ----- src/backend/utils/adt/misc.c | 7 ------- src/bin/pg_checksums/pg_checksums.c | 4 ---- src/bin/pg_rewind/file_ops.c | 4 ---- src/common/file_utils.c | 23 ----------------------- src/include/port.h | 1 - src/include/port/win32_port.h | 1 - src/port/dirmod.c | 16 ---------------- 10 files changed, 2 insertions(+), 78 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Replace pgwin32_is_junction() with lstat(). @ 2024-11-07 23:19 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 3+ messages in thread From: Andrew Dunstan @ 2024-11-07 23:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Replace pgwin32_is_junction() with lstat(). Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and unlink() can unlink them, there is no need for conditional code for Windows in a few places. That was expressed by testing for WIN32 or S_ISLNK, which we can now constant-fold. The coding around pgwin32_is_junction() was a bit suspect anyway, as we never checked for errors, and we also know that errors can be spuriously reported because of transient sharing violations on this OS. The lstat()-based code has handling for that. This also reverts 4fc6b6ee on master only. That was done because lstat() didn't previously work for symlinks (junction points), but now it does. Tested-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com (cherry picked from commit 5fc88c5d53e43fa7dcea93499d230a0bf70f4f77) Author: Thomas Munro <tmunro@postgresql.org> Author: Alexandra Wang <alexandra.wang.oss@gmail.com> Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f95ad555de5623588bcc6e48fe8a3fd50d721216 Author: Thomas Munro <tmunro@postgresql.org> Modified Files -------------- src/backend/backup/basebackup.c | 12 +----------- src/backend/commands/tablespace.c | 7 +------ src/backend/storage/file/fd.c | 5 ----- src/backend/utils/adt/misc.c | 7 ------- src/bin/pg_checksums/pg_checksums.c | 4 ---- src/bin/pg_rewind/file_ops.c | 4 ---- src/common/file_utils.c | 23 ----------------------- src/include/port.h | 1 - src/include/port/win32_port.h | 1 - src/port/dirmod.c | 16 ---------------- 10 files changed, 2 insertions(+), 78 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Replace pgwin32_is_junction() with lstat(). @ 2024-11-07 23:19 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 3+ messages in thread From: Andrew Dunstan @ 2024-11-07 23:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Replace pgwin32_is_junction() with lstat(). Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and unlink() can unlink them, there is no need for conditional code for Windows in a few places. That was expressed by testing for WIN32 or S_ISLNK, which we can now constant-fold. The coding around pgwin32_is_junction() was a bit suspect anyway, as we never checked for errors, and we also know that errors can be spuriously reported because of transient sharing violations on this OS. The lstat()-based code has handling for that. This also reverts 4fc6b6ee on master only. That was done because lstat() didn't previously work for symlinks (junction points), but now it does. Tested-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com (cherry picked from commit 5fc88c5d53e43fa7dcea93499d230a0bf70f4f77) Author: Thomas Munro <tmunro@postgresql.org> Author: Alexandra Wang <alexandra.wang.oss@gmail.com> Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ca9921936ea352df30db2955fb2662695d8377be Author: Thomas Munro <tmunro@postgresql.org> Modified Files -------------- src/backend/commands/tablespace.c | 7 +------ src/backend/replication/basebackup.c | 12 +----------- src/backend/storage/file/fd.c | 5 ----- src/backend/utils/adt/misc.c | 7 ------- src/bin/pg_checksums/pg_checksums.c | 4 ---- src/bin/pg_rewind/file_ops.c | 4 ---- src/common/file_utils.c | 23 ----------------------- src/include/port.h | 1 - src/include/port/win32_port.h | 1 - src/port/dirmod.c | 16 ---------------- 10 files changed, 2 insertions(+), 78 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-11-07 23:19 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-06 00:52 pgsql: Replace pgwin32_is_junction() with lstat(). Thomas Munro <tmunro@postgresql.org> 2024-11-07 23:19 pgsql: Replace pgwin32_is_junction() with lstat(). Andrew Dunstan <andrew@dunslane.net> 2024-11-07 23:19 pgsql: Replace pgwin32_is_junction() with lstat(). Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox