pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use correct LSN for error reporting in pg_walinspect 2+ messages / 1 participants [nested] [flat]
* pgsql: Use correct LSN for error reporting in pg_walinspect @ 2022-08-18 21:23 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2022-08-18 21:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use correct LSN for error reporting in pg_walinspect Usage of ReadNextXLogRecord()'s first_record parameter for error reporting isn't always correct. For instance, in GetWALRecordsInfo() and GetWalStats(), we're reading multiple records, and first_record is always passed as the LSN of the first record which is then used for error reporting for later WAL record read failures. This isn't correct. The correct parameter to use for error reports in case of WAL reading failures is xlogreader->EndRecPtr. This change fixes it. While on it, removed an unnecessary Assert in pg_walinspect code. Reported-by: Robert Haas Author: Bharath Rupireddy Reviewed-by: Robert Haas Discussion: https://www.postgresql.org/message-id/CA%2BTgmoZAOGzPUifrcZRjFZ2vbtcw3mp-mN6UgEoEcQg6bY3OVg%40mail.g... Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d9fbb8862959912c5266364059c0abeda0c93bbf Modified Files -------------- contrib/pg_walinspect/pg_walinspect.c | 53 +++++++++++++++-------------------- 1 file changed, 23 insertions(+), 30 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Use correct LSN for error reporting in pg_walinspect @ 2022-08-18 21:24 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2022-08-18 21:24 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use correct LSN for error reporting in pg_walinspect Usage of ReadNextXLogRecord()'s first_record parameter for error reporting isn't always correct. For instance, in GetWALRecordsInfo() and GetWalStats(), we're reading multiple records, and first_record is always passed as the LSN of the first record which is then used for error reporting for later WAL record read failures. This isn't correct. The correct parameter to use for error reports in case of WAL reading failures is xlogreader->EndRecPtr. This change fixes it. While on it, removed an unnecessary Assert in pg_walinspect code. Reported-by: Robert Haas Author: Bharath Rupireddy Reviewed-by: Robert Haas Discussion: https://www.postgresql.org/message-id/CA%2BTgmoZAOGzPUifrcZRjFZ2vbtcw3mp-mN6UgEoEcQg6bY3OVg%40mail.g... Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/72af71aad9ce541ecea67ceaa7961ca39f89f227 Modified Files -------------- contrib/pg_walinspect/pg_walinspect.c | 53 +++++++++++++++-------------------- 1 file changed, 23 insertions(+), 30 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-08-18 21:24 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-18 21:23 pgsql: Use correct LSN for error reporting in pg_walinspect Jeff Davis <jdavis@postgresql.org> 2022-08-18 21:24 pgsql: Use correct LSN for error reporting in pg_walinspect Jeff Davis <jdavis@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox