pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pgstat: Acquire lock when reading variable-numbered stats 2+ messages / 1 participants [nested] [flat]
* pgsql: pgstat: Acquire lock when reading variable-numbered stats @ 2022-08-23 03:20 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 2+ messages in thread From: Andres Freund @ 2022-08-23 03:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstat: Acquire lock when reading variable-numbered stats Somewhere during the development of the patch acquiring a lock during read access to variable-numbered stats got lost. The missing lock acquisition won't cause corruption, but can lead to reading torn values when accessing stats. Add the missing lock acquisitions. Reported-by: Greg Stark <stark@mit.edu> Reviewed-by: "Drouvot, Bertrand" <bdrouvot@amazon.com> Reviewed-by: Andres Freund <andres@anarazel.de> Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Discussion: https://postgr.es/m/CAM-w4HMYkM_DkYhWtUGV+qE_rrBxKOzOF0+5faozxO3vXrc9wA@mail.gmail.com Backpatch: 15- Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cd063344fb801a90a40923a5b8aefe4eb8d80762 Modified Files -------------- src/backend/utils/activity/pgstat.c | 9 +++++++++ src/backend/utils/activity/pgstat_shmem.c | 16 ++++++++++++++++ src/include/utils/pgstat_internal.h | 1 + 3 files changed, 26 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pgstat: Acquire lock when reading variable-numbered stats @ 2022-08-23 03:20 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 2+ messages in thread From: Andres Freund @ 2022-08-23 03:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstat: Acquire lock when reading variable-numbered stats Somewhere during the development of the patch acquiring a lock during read access to variable-numbered stats got lost. The missing lock acquisition won't cause corruption, but can lead to reading torn values when accessing stats. Add the missing lock acquisitions. Reported-by: Greg Stark <stark@mit.edu> Reviewed-by: "Drouvot, Bertrand" <bdrouvot@amazon.com> Reviewed-by: Andres Freund <andres@anarazel.de> Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Discussion: https://postgr.es/m/CAM-w4HMYkM_DkYhWtUGV+qE_rrBxKOzOF0+5faozxO3vXrc9wA@mail.gmail.com Backpatch: 15- Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/045ec347857b66e8a494b2c12126a6d476702065 Modified Files -------------- src/backend/utils/activity/pgstat.c | 9 +++++++++ src/backend/utils/activity/pgstat_shmem.c | 16 ++++++++++++++++ src/include/utils/pgstat_internal.h | 1 + 3 files changed, 26 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-08-23 03:20 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-23 03:20 pgsql: pgstat: Acquire lock when reading variable-numbered stats Andres Freund <andres@anarazel.de> 2022-08-23 03:20 pgsql: pgstat: Acquire lock when reading variable-numbered stats Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox