pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. 7+ messages / 1 participants [nested] [flat]
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/464db46760d2a89e1933038330f1d84210115886 Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/529d8f3736a1c62dc00ee272e04a6decaacc300b Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a94b019d44e5e9cfa6e57dda52bcfaf2535e7acf Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/68bfe36c5173e8e121f0a9eaf0310c1a7ba6d555 Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6fd58ca7703a491e585411e4fb0880c69e640cad Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8acd8f8690ed10f421a54e9b3fb6d49f2ce226f8 Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. @ 2022-08-30 21:29 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-30 21:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On NetBSD, force dynamic symbol resolution at postmaster start. The default of lazy symbol resolution means that when the postmaster first reaches the select() call in ServerLoop, it'll need to resolve the link to that libc entry point. NetBSD's dynamic loader takes an internal lock while doing that, and if a signal interrupts the operation then there is a risk of self-deadlock should the signal handler do anything that requires that lock, as several of the postmaster signal handlers do. The window for this is pretty narrow, and timing considerations make it unlikely that a signal would arrive right then anyway. But it's semi-repeatable on slow single-CPU machines, and in principle the race could happen with any hardware. The least messy solution to this is to force binding of dynamic symbols at postmaster start, using the "-z now" linker option. While we're at it, also use "-z relro" so as to provide a small security gain. It's not entirely clear whether any other platforms share this issue, but for now we'll assume it's NetBSD-specific. (We might later try to use "-z now" on more platforms for performance reasons, but that would not likely be something to back-patch.) Report and patch by me; the idea to fix it this way is from Andres Freund. Discussion: https://postgr.es/m/3384826.1661802235@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5bed28e699ece990372763f1acfd7a958d873a41 Modified Files -------------- src/template/netbsd | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2022-08-30 21:29 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-30 21:29 pgsql: On NetBSD, force dynamic symbol resolution at postmaster start. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox