pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Reject bogus output from uuid_create(3).
7+ messages / 1 participants
[nested] [flat]

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4b6d218e369b69c20ca40d4ccefc02350f38c24

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/100a8ca2c2852a990135f6de4268b89f6ab19449

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e55ccb3b179cbfc5b436339cf1a71d21a73c79dc

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a61095aa7946ffe6959279a32813681b53afb60e

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/23fe89a612238e269b621245fe9e4c882b9ef07b

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4d3f54bd7a0da755e4c469026ee51891a2ed53b7

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject bogus output from uuid_create(3).
@ 2022-09-09 16:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 16:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject bogus output from uuid_create(3).

When using the BSD UUID functions, contrib/uuid-ossp expects
uuid_create() to produce a version-1 UUID.  FreeBSD still does so,
but in recent NetBSD releases that function produces a version-4
(random) UUID instead.  That's not acceptable for our purposes:
if the user wanted v4 she would have asked for v4, not v1.
Hence, check the version digit and complain if it's not '1'.

Also drop the documentation's claim that the NetBSD implementation
is usable.  It might be, depending on which OS version you're using,
but we're not going to get into that kind of detail.

(Maybe someday we should ditch all these external libraries
and just write our own UUID code, but today is not that day.)

Nazir Bilal Yavuz, with cosmetic adjustments and docs by me.
Backpatch to all supported versions.

Discussion: https://postgr.es/m/3848059.1661038772@sss.pgh.pa.us
Discussion: https://postgr.es/m/17358-89806e7420797025@postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/95028d9de422e395d478da4dcda0a640989156d5

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c  | 12 ++++++++++++
doc/src/sgml/installation.sgml |  2 +-
doc/src/sgml/uuid-ossp.sgml    |  2 +-
3 files changed, 14 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2022-09-09 16:41 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 16:41 pgsql: Reject bogus output from uuid_create(3). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox