pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix possible omission of variable storage markers in ECPG.
7+ messages / 1 participants
[nested] [flat]

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b7050e2584803a6abe71fb0b94a63b63e59cff9c

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fbb54d742ac888370e3221c556c5f336a1f4e888

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/be0b0528cb64d49750fcb632faa2cfcd8d920be2

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a6618842fac3baaf486dda5b563c61bbdb7a06ae

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9fbc6d5483b00006351374ef6b3bc176c0175ed5

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fe4e151d4a7c4da728a71167148afdb4bcb4d4dd

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix possible omission of variable storage markers in ECPG.
@ 2022-09-09 19:34 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-09-09 19:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix possible omission of variable storage markers in ECPG.

The ECPG preprocessor converted code such as

static varchar str1[10], str2[20], str3[30];

into

static  struct varchar_1  { int len; char arr[ 10 ]; }  str1 ;
        struct varchar_2  { int len; char arr[ 20 ]; }  str2 ;
        struct varchar_3  { int len; char arr[ 30 ]; }  str3 ;

thus losing the storage attribute for the later variables.
Repeat the declaration for each such variable.

(Note that this occurred only for variables declared "varchar"
or "bytea", which may help explain how it escaped detection
for so long.)

Andrey Sokolov

Discussion: https://postgr.es/m/942241662288242@mail.yandex.ru

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8fe26bca1c9754b72eb08cea46cf901b61cc9652

Modified Files
--------------
src/interfaces/ecpg/preproc/ecpg.trailer           |   8 +-
src/interfaces/ecpg/preproc/type.h                 |   1 +
.../ecpg/test/expected/preproc-variable.c          |  93 +++++++-----
.../ecpg/test/expected/preproc-variable.stderr     | 162 ++++++++++-----------
.../ecpg/test/expected/preproc-variable.stdout     |   1 +
src/interfaces/ecpg/test/preproc/variable.pgc      |   9 ++
6 files changed, 151 insertions(+), 123 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2022-09-09 19:34 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>
2022-09-09 19:34 pgsql: Fix possible omission of variable storage markers in ECPG. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox