pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia 4+ messages / 2 participants [nested] [flat]
* pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia @ 2022-09-15 13:46 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 4+ messages in thread From: Noah Misch @ 2022-09-15 13:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit. After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag, failure to reset it caused assertion failures. In non-assert builds, it made the system fail to achieve the objectives listed in that commit; chiefly, we might emit a spurious log message. Back-patch to v15, where that commit first appeared. Bharath Rupireddy and Kyotaro Horiguchi. Reviewed by Dilip Kumar, Nathan Bossart and Michael Paquier. Reported by Dilip Kumar. Discussion: https://postgr.es/m/CAFiTN-sE3ry=ycMPVtC+Djw4Fd7gbUGVv_qqw6qfzp=JLvqT3g@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b4f584f9d2a1b50d1f5ce88408a54bb11f1c8353 Modified Files -------------- src/backend/access/transam/xlogrecovery.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia @ 2022-09-15 13:46 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 4+ messages in thread From: Noah Misch @ 2022-09-15 13:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit. After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag, failure to reset it caused assertion failures. In non-assert builds, it made the system fail to achieve the objectives listed in that commit; chiefly, we might emit a spurious log message. Back-patch to v15, where that commit first appeared. Bharath Rupireddy and Kyotaro Horiguchi. Reviewed by Dilip Kumar, Nathan Bossart and Michael Paquier. Reported by Dilip Kumar. Discussion: https://postgr.es/m/CAFiTN-sE3ry=ycMPVtC+Djw4Fd7gbUGVv_qqw6qfzp=JLvqT3g@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e36cbef04bd59f5e2e56a180475d64b0dc06d069 Modified Files -------------- src/backend/access/transam/xlogrecovery.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia @ 2025-04-06 06:51 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-04-06 06:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit. After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag, failure to reset it caused assertion failures. In non-assert builds, it made the system fail to achieve the objectives listed in that commit; chiefly, we might emit a spurious log message. Back-patch to v15, where that commit first appeared. Bharath Rupireddy and Kyotaro Horiguchi. Reviewed by Dilip Kumar, Nathan Bossart and Michael Paquier. Reported by Dilip Kumar. This commit has been applied as of b4f584f9d2a1 in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me. Tests have been conducted by the both of us. Discussion: https://postgr.es/m/CAFiTN-sE3ry=ycMPVtC+Djw4Fd7gbUGVv_qqw6qfzp=JLvqT3g@mail.gmail.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3635a0a35aafd3bfa80b7a809bc6e91ccd36606a Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia @ 2025-04-06 06:51 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-04-06 06:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit. After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag, failure to reset it caused assertion failures. In non-assert builds, it made the system fail to achieve the objectives listed in that commit; chiefly, we might emit a spurious log message. Back-patch to v15, where that commit first appeared. Bharath Rupireddy and Kyotaro Horiguchi. Reviewed by Dilip Kumar, Nathan Bossart and Michael Paquier. Reported by Dilip Kumar. This commit has been applied as of b4f584f9d2a1 in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me. Tests have been conducted by the both of us. Discussion: https://postgr.es/m/CAFiTN-sE3ry=ycMPVtC+Djw4Fd7gbUGVv_qqw6qfzp=JLvqT3g@mail.gmail.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/69a498eb6465da053604e64654179eaa62423681 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-04-06 06:51 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-09-15 13:46 pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia Noah Misch <noah@leadboat.com> 2022-09-15 13:46 pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia Noah Misch <noah@leadboat.com> 2025-04-06 06:51 pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia Michael Paquier <michael@paquier.xyz> 2025-04-06 06:51 pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox