pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Harmonize more parameter names in bulk.
3+ messages / 2 participants
[nested] [flat]

* pgsql: Harmonize more parameter names in bulk.
@ 2022-09-20 20:10  Peter Geoghegan <pg@bowt.ie>
  0 siblings, 1 reply; 3+ messages in thread

From: Peter Geoghegan @ 2022-09-20 20:10 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Harmonize more parameter names in bulk.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in optimizer, parser,
utility, libpq, and "commands" code, as well as in remaining library
code.  Do the same for all code related to frontend programs (with the
exception of pg_dump/pg_dumpall related code).

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.  Later commits will handle
ecpg and pg_dump/pg_dumpall.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a601366a460f68472bf70c4d94c57baa0a3ed1b2

Modified Files
--------------
src/backend/backup/basebackup.c                  |  2 +-
src/backend/bootstrap/bootstrap.c                | 10 ++--
src/backend/commands/event_trigger.c             |  2 +-
src/backend/commands/explain.c                   |  2 +-
src/backend/commands/indexcmds.c                 |  2 +-
src/backend/commands/lockcmds.c                  |  2 +-
src/backend/commands/opclasscmds.c               |  2 +-
src/backend/commands/schemacmds.c                |  6 +-
src/backend/commands/tablecmds.c                 |  6 +-
src/backend/commands/trigger.c                   |  8 +--
src/backend/lib/dshash.c                         |  2 +-
src/backend/lib/integerset.c                     |  4 +-
src/backend/libpq/be-secure-openssl.c            |  4 +-
src/backend/optimizer/geqo/geqo_selection.c      |  2 +-
src/backend/optimizer/plan/createplan.c          |  2 +-
src/backend/optimizer/plan/planner.c             |  4 +-
src/backend/optimizer/util/plancat.c             |  3 +-
src/backend/parser/gram.y                        |  3 +-
src/backend/parser/parse_clause.c                |  2 +-
src/backend/parser/parse_utilcmd.c               |  2 +-
src/backend/partitioning/partbounds.c            |  6 +-
src/backend/postmaster/postmaster.c              |  6 +-
src/backend/statistics/extended_stats.c          |  4 +-
src/backend/utils/adt/datetime.c                 | 22 +++----
src/backend/utils/adt/geo_ops.c                  |  8 +--
src/backend/utils/adt/jsonb.c                    | 12 ++--
src/backend/utils/adt/jsonb_util.c               | 74 ++++++++++++------------
src/backend/utils/adt/jsonpath_exec.c            |  2 +-
src/backend/utils/adt/like.c                     |  4 +-
src/backend/utils/adt/numeric.c                  |  6 +-
src/backend/utils/adt/rangetypes.c               |  4 +-
src/backend/utils/adt/ri_triggers.c              |  2 +-
src/backend/utils/adt/timestamp.c                |  4 +-
src/backend/utils/adt/xml.c                      |  2 +-
src/backend/utils/cache/relmapper.c              |  2 +-
src/backend/utils/error/elog.c                   |  2 +-
src/backend/utils/misc/guc.c                     |  2 +-
src/backend/utils/misc/queryjumble.c             |  3 +-
src/backend/utils/sort/tuplesortvariants.c       |  2 +-
src/backend/utils/time/snapmgr.c                 | 29 +++++-----
src/bin/initdb/initdb.c                          |  2 +-
src/bin/pg_amcheck/pg_amcheck.c                  |  2 +-
src/bin/pg_basebackup/pg_receivewal.c            |  2 +-
src/bin/pg_basebackup/streamutil.h               |  2 +-
src/bin/pg_basebackup/walmethods.h               |  8 +--
src/bin/pg_rewind/file_ops.h                     |  4 +-
src/bin/pg_rewind/pg_rewind.h                    |  2 +-
src/bin/pg_upgrade/info.c                        |  2 +-
src/bin/pg_upgrade/pg_upgrade.h                  |  2 +-
src/bin/pg_upgrade/relfilenumber.c               |  2 +-
src/bin/pg_verifybackup/pg_verifybackup.c        |  2 +-
src/bin/pg_waldump/compat.c                      |  6 +-
src/bin/pgbench/pgbench.h                        |  8 +--
src/bin/psql/describe.h                          |  6 +-
src/bin/scripts/common.h                         |  2 +-
src/fe_utils/cancel.c                            |  4 +-
src/include/bootstrap/bootstrap.h                |  4 +-
src/include/commands/alter.h                     |  2 +-
src/include/commands/conversioncmds.h            |  2 +-
src/include/commands/matview.h                   |  2 +-
src/include/commands/policy.h                    |  2 +-
src/include/commands/publicationcmds.h           |  2 +-
src/include/commands/schemacmds.h                |  4 +-
src/include/commands/seclabel.h                  |  2 +-
src/include/commands/sequence.h                  |  8 +--
src/include/commands/tablecmds.h                 |  2 +-
src/include/commands/tablespace.h                |  4 +-
src/include/commands/trigger.h                   | 14 ++---
src/include/commands/typecmds.h                  |  2 +-
src/include/common/fe_memutils.h                 |  4 +-
src/include/common/kwlookup.h                    |  2 +-
src/include/common/scram-common.h                |  2 +-
src/include/fe_utils/cancel.h                    |  2 +-
src/include/fe_utils/mbprint.h                   |  3 +-
src/include/fe_utils/parallel_slot.h             |  2 +-
src/include/fe_utils/recovery_gen.h              |  2 +-
src/include/fe_utils/simple_list.h               |  2 +-
src/include/fe_utils/string_utils.h              |  2 +-
src/include/foreign/foreign.h                    |  5 +-
src/include/funcapi.h                            |  2 +-
src/include/libpq/pqmq.h                         |  2 +-
src/include/nodes/extensible.h                   |  4 +-
src/include/nodes/nodes.h                        |  2 +-
src/include/nodes/params.h                       |  4 +-
src/include/nodes/pg_list.h                      |  4 +-
src/include/nodes/value.h                        |  2 +-
src/include/optimizer/appendinfo.h               |  2 +-
src/include/optimizer/clauses.h                  |  4 +-
src/include/optimizer/cost.h                     |  4 +-
src/include/optimizer/paths.h                    |  4 +-
src/include/optimizer/planmain.h                 |  2 +-
src/include/optimizer/prep.h                     |  2 +-
src/include/parser/analyze.h                     |  2 +-
src/include/parser/parse_agg.h                   |  2 +-
src/include/parser/parse_oper.h                  |  4 +-
src/include/parser/parse_relation.h              |  2 +-
src/include/partitioning/partbounds.h            |  4 +-
src/include/pgstat.h                             | 10 ++--
src/include/pgtime.h                             |  4 +-
src/include/port.h                               |  8 +--
src/include/postmaster/bgworker.h                |  2 +-
src/include/postmaster/syslogger.h               |  2 +-
src/include/rewrite/rewriteManip.h               |  2 +-
src/include/snowball/libstemmer/header.h         |  2 +-
src/include/statistics/extended_stats_internal.h |  2 +-
src/include/statistics/statistics.h              |  4 +-
src/include/tcop/cmdtag.h                        |  2 +-
src/include/tsearch/ts_utils.h                   |  4 +-
src/include/utils/acl.h                          |  6 +-
src/include/utils/attoptcache.h                  |  2 +-
src/include/utils/builtins.h                     |  8 +--
src/include/utils/datetime.h                     |  2 +-
src/include/utils/jsonb.h                        |  6 +-
src/include/utils/multirangetypes.h              |  6 +-
src/include/utils/numeric.h                      |  2 +-
src/include/utils/pgstat_internal.h              |  4 +-
src/include/utils/rangetypes.h                   |  4 +-
src/include/utils/regproc.h                      |  2 +-
src/include/utils/relcache.h                     |  2 +-
src/include/utils/relmapper.h                    |  2 +-
src/include/utils/selfuncs.h                     |  4 +-
src/include/utils/snapmgr.h                      |  2 +-
src/include/utils/timestamp.h                    |  4 +-
src/include/utils/tuplesort.h                    |  2 +-
src/include/utils/xml.h                          |  2 +-
src/interfaces/libpq/fe-connect.c                |  2 +-
src/interfaces/libpq/fe-exec.c                   | 22 +++----
src/interfaces/libpq/fe-secure-common.h          |  4 +-
src/interfaces/libpq/fe-secure-openssl.c         |  4 +-
src/interfaces/libpq/libpq-fe.h                  |  4 +-
src/pl/plpgsql/src/pl_exec.c                     |  2 +-
131 files changed, 297 insertions(+), 293 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Harmonize more parameter names in bulk.
@ 2022-09-20 20:47  Andres Freund <andres@anarazel.de>
  parent: Peter Geoghegan <pg@bowt.ie>
  0 siblings, 1 reply; 3+ messages in thread

From: Andres Freund @ 2022-09-20 20:47 UTC (permalink / raw)
  To: Peter Geoghegan <pg@bowt.ie>; +Cc: pgsql-committers@lists.postgresql.org

Hi,

On 2022-09-20 20:10:38 +0000, Peter Geoghegan wrote:
> Harmonize more parameter names in bulk.

This seems to have broken cpluspluscheck:

https://cirrus-ci.com/task/5694996828389376

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Harmonize more parameter names in bulk.
@ 2022-09-20 20:52  Peter Geoghegan <pg@bowt.ie>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Geoghegan @ 2022-09-20 20:52 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Sep 20, 2022 at 1:47 PM Andres Freund <andres@anarazel.de> wrote:
> This seems to have broken cpluspluscheck:
>
> https://cirrus-ci.com/task/5694996828389376

Oops. Will fix that now.

-- 
Peter Geoghegan





^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-09-20 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 20:10 pgsql: Harmonize more parameter names in bulk. Peter Geoghegan <pg@bowt.ie>
2022-09-20 20:47 ` Andres Freund <andres@anarazel.de>
2022-09-20 20:52   ` Peter Geoghegan <pg@bowt.ie>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox