pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Disallow MERGE cleanly for foreign partitions 2+ messages / 1 participants [nested] [flat]
* pgsql: Disallow MERGE cleanly for foreign partitions @ 2022-10-15 18:23 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2022-10-15 18:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow MERGE cleanly for foreign partitions While directly targetting a foreign table with MERGE was already expressly forbidden, we failed to catch the case of a partitioned table that has a foreign table as a partition; and the result if you try is an incomprehensible error. Fix that by adding a specific check. Backpatch to 15. Reported-by: Tatsuhiro Nakamori <bt22nakamorit@oss.nttdata.com> Discussion: https://postgr.es/m/bt22nakamorit@oss.nttdata.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cba4e78f3599f7edc3fb53d1b094f037fbb8158a Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 5 +++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 4 ++++ src/backend/optimizer/plan/createplan.c | 20 ++++++++++++++++++++ 3 files changed, 29 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Disallow MERGE cleanly for foreign partitions @ 2022-10-15 18:23 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Alvaro Herrera @ 2022-10-15 18:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow MERGE cleanly for foreign partitions While directly targetting a foreign table with MERGE was already expressly forbidden, we failed to catch the case of a partitioned table that has a foreign table as a partition; and the result if you try is an incomprehensible error. Fix that by adding a specific check. Backpatch to 15. Reported-by: Tatsuhiro Nakamori <bt22nakamorit@oss.nttdata.com> Discussion: https://postgr.es/m/bt22nakamorit@oss.nttdata.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/16d11d68437a6a37af1fea08d4a29ef463f0d62c Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 5 +++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 4 ++++ src/backend/optimizer/plan/createplan.c | 20 ++++++++++++++++++++ 3 files changed, 29 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-10-15 18:23 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-10-15 18:23 pgsql: Disallow MERGE cleanly for foreign partitions Alvaro Herrera <alvherre@alvh.no-ip.org> 2022-10-15 18:23 pgsql: Disallow MERGE cleanly for foreign partitions Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox