pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix calculation related to temporary WAL segment name in basic_a 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix calculation related to temporary WAL segment name in basic_a @ 2022-10-17 02:40 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2022-10-17 02:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix calculation related to temporary WAL segment name in basic_archive The file name used for its temporary destination, before renaming it to the real deal, has been using a microseconds in a timestamp aimed to be originally in milli-seconds. This is harmless as this is aimed at being a safeguard against name collisions (note MyProcPid in the name), but let's be correct with the maths. While on it, add a note in the module's makefile to document why installcheck is not supported. Author: Nathan Bossart Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/20221014044106.GA1673343@nathanxps13 Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c68a1839902daeb42cf1ebc89edfdd91c00e5091 Modified Files -------------- contrib/basic_archive/Makefile | 3 ++- contrib/basic_archive/basic_archive.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix calculation related to temporary WAL segment name in basic_a @ 2022-10-17 02:40 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2022-10-17 02:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix calculation related to temporary WAL segment name in basic_archive The file name used for its temporary destination, before renaming it to the real deal, has been using a microseconds in a timestamp aimed to be originally in milli-seconds. This is harmless as this is aimed at being a safeguard against name collisions (note MyProcPid in the name), but let's be correct with the maths. While on it, add a note in the module's makefile to document why installcheck is not supported. Author: Nathan Bossart Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/20221014044106.GA1673343@nathanxps13 Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9ebcb5ffdf3a1f49388c38ba5273370f49bf7d19 Modified Files -------------- contrib/basic_archive/Makefile | 3 ++- contrib/basic_archive/basic_archive.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-10-17 02:40 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-10-17 02:40 pgsql: Fix calculation related to temporary WAL segment name in basic_a Michael Paquier <michael@paquier.xyz> 2022-10-17 02:40 pgsql: Fix calculation related to temporary WAL segment name in basic_a Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox