pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
7+ messages / 1 participants
[nested] [flat]

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/797e313dc9aed83e28e9f1d08a281ea48c560cd2

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4a41a069e7ac78e0a8b700fac181f59a234f8606

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b21615d1e9b04d8098ec04abc32d308659085a45

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e9377e3e53e6d7dc9458e296aba06af6b58dae7a

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ecf4ce689a7c3d91b912f3f41d8502f322592619

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2f26cec4884366cc23737c5a9b7797935057ce38

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Reject non-ON-SELECT rules that are named "_RETURN".
@ 2022-10-17 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2022-10-17 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject non-ON-SELECT rules that are named "_RETURN".

DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN".  But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN".  In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.

Per bug #17646 from Kui Liu.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/65c1106d8c5bea72b30c257d992c0d42f1b52440

Modified Files
--------------
src/backend/rewrite/rewriteDefine.c | 12 ++++++++++++
1 file changed, 12 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2022-10-17 16:14 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>
2022-10-17 16:14 pgsql: Reject non-ON-SELECT rules that are named "_RETURN". Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox