pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix executing invalidation messages generated by subtransactions 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix executing invalidation messages generated by subtransactions @ 2022-10-21 04:43 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2022-10-21 04:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix executing invalidation messages generated by subtransactions during decoding. This problem has been introduced by commit 272248a0c1 where we started assigning the subtransactions to the top-level transaction when we mark both the top-level transaction and its subtransactions as containing catalog changes. After we assign subtransactions to the top-level transaction, we were not allowed to execute any invalidations associated with it when we decide to skip the transaction. The reason to assign the subtransactions to the top-level transaction was to avoid the assertion failure in AssertTXNLsnOrder() as they have the same LSN when we sometimes start accumulating transaction changes for partial transactions after the restart. Now that with commit 64ff0fe4e8, we skip this assertion check until we reach the LSN at which we start decoding the contents of the transaction, so, there is no reason for such an assignment anymore. The assignment change was introduced in 15 and prior versions but this bug doesn't exist in branches prior to 14 since we don't add invalidation messages to subtransactions. We decided to backpatch through 11 for consistency but not for 10 since its final release is near. Reported-by: Kuroda Hayato Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/343afa9671060c3d6482d1252207a64cc5ddd23d Modified Files -------------- .../expected/catalog_change_snapshot.out | 45 ++++++++++++++++++++++ .../specs/catalog_change_snapshot.spec | 7 ++++ src/backend/replication/logical/snapbuild.c | 3 -- 3 files changed, 52 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix executing invalidation messages generated by subtransactions @ 2022-10-21 04:43 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2022-10-21 04:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix executing invalidation messages generated by subtransactions during decoding. This problem has been introduced by commit 272248a0c1 where we started assigning the subtransactions to the top-level transaction when we mark both the top-level transaction and its subtransactions as containing catalog changes. After we assign subtransactions to the top-level transaction, we were not allowed to execute any invalidations associated with it when we decide to skip the transaction. The reason to assign the subtransactions to the top-level transaction was to avoid the assertion failure in AssertTXNLsnOrder() as they have the same LSN when we sometimes start accumulating transaction changes for partial transactions after the restart. Now that with commit 64ff0fe4e8, we skip this assertion check until we reach the LSN at which we start decoding the contents of the transaction, so, there is no reason for such an assignment anymore. The assignment change was introduced in 15 and prior versions but this bug doesn't exist in branches prior to 14 since we don't add invalidation messages to subtransactions. We decided to backpatch through 11 for consistency but not for 10 since its final release is near. Reported-by: Kuroda Hayato Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4fbe6096b954092abc460adaddd365d5049d40f1 Modified Files -------------- .../expected/catalog_change_snapshot.out | 45 ++++++++++++++++++++++ .../specs/catalog_change_snapshot.spec | 7 ++++ src/backend/replication/logical/snapbuild.c | 3 -- 3 files changed, 52 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix executing invalidation messages generated by subtransactions @ 2022-10-21 04:43 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2022-10-21 04:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix executing invalidation messages generated by subtransactions during decoding. This problem has been introduced by commit 272248a0c1 where we started assigning the subtransactions to the top-level transaction when we mark both the top-level transaction and its subtransactions as containing catalog changes. After we assign subtransactions to the top-level transaction, we were not allowed to execute any invalidations associated with it when we decide to skip the transaction. The reason to assign the subtransactions to the top-level transaction was to avoid the assertion failure in AssertTXNLsnOrder() as they have the same LSN when we sometimes start accumulating transaction changes for partial transactions after the restart. Now that with commit 64ff0fe4e8, we skip this assertion check until we reach the LSN at which we start decoding the contents of the transaction, so, there is no reason for such an assignment anymore. The assignment change was introduced in 15 and prior versions but this bug doesn't exist in branches prior to 14 since we don't add invalidation messages to subtransactions. We decided to backpatch through 11 for consistency but not for 10 since its final release is near. Reported-by: Kuroda Hayato Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/38dbaaf273877355c2deeafa4b479d315a78196b Modified Files -------------- src/backend/replication/logical/snapbuild.c | 3 --- 1 file changed, 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix executing invalidation messages generated by subtransactions @ 2022-10-21 04:43 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2022-10-21 04:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix executing invalidation messages generated by subtransactions during decoding. This problem has been introduced by commit 272248a0c1 where we started assigning the subtransactions to the top-level transaction when we mark both the top-level transaction and its subtransactions as containing catalog changes. After we assign subtransactions to the top-level transaction, we were not allowed to execute any invalidations associated with it when we decide to skip the transaction. The reason to assign the subtransactions to the top-level transaction was to avoid the assertion failure in AssertTXNLsnOrder() as they have the same LSN when we sometimes start accumulating transaction changes for partial transactions after the restart. Now that with commit 64ff0fe4e8, we skip this assertion check until we reach the LSN at which we start decoding the contents of the transaction, so, there is no reason for such an assignment anymore. The assignment change was introduced in 15 and prior versions but this bug doesn't exist in branches prior to 14 since we don't add invalidation messages to subtransactions. We decided to backpatch through 11 for consistency but not for 10 since its final release is near. Reported-by: Kuroda Hayato Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/02600886c8a8c47f61d8911fdf2938904287b62c Modified Files -------------- src/backend/replication/logical/snapbuild.c | 3 --- 1 file changed, 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix executing invalidation messages generated by subtransactions @ 2022-10-21 04:43 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Amit Kapila @ 2022-10-21 04:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix executing invalidation messages generated by subtransactions during decoding. This problem has been introduced by commit 272248a0c1 where we started assigning the subtransactions to the top-level transaction when we mark both the top-level transaction and its subtransactions as containing catalog changes. After we assign subtransactions to the top-level transaction, we were not allowed to execute any invalidations associated with it when we decide to skip the transaction. The reason to assign the subtransactions to the top-level transaction was to avoid the assertion failure in AssertTXNLsnOrder() as they have the same LSN when we sometimes start accumulating transaction changes for partial transactions after the restart. Now that with commit 64ff0fe4e8, we skip this assertion check until we reach the LSN at which we start decoding the contents of the transaction, so, there is no reason for such an assignment anymore. The assignment change was introduced in 15 and prior versions but this bug doesn't exist in branches prior to 14 since we don't add invalidation messages to subtransactions. We decided to backpatch through 11 for consistency but not for 10 since its final release is near. Reported-by: Kuroda Hayato Author: Masahiko Sawada Reviewed-by: Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/216af69aec0da78cca37b5b8de16c92ee9a7a3a0 Modified Files -------------- src/backend/replication/logical/snapbuild.c | 3 --- 1 file changed, 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-10-21 04:43 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-10-21 04:43 pgsql: Fix executing invalidation messages generated by subtransactions Amit Kapila <akapila@postgresql.org> 2022-10-21 04:43 pgsql: Fix executing invalidation messages generated by subtransactions Amit Kapila <akapila@postgresql.org> 2022-10-21 04:43 pgsql: Fix executing invalidation messages generated by subtransactions Amit Kapila <akapila@postgresql.org> 2022-10-21 04:43 pgsql: Fix executing invalidation messages generated by subtransactions Amit Kapila <akapila@postgresql.org> 2022-10-21 04:43 pgsql: Fix executing invalidation messages generated by subtransactions Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox