pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix alter_table.sql test case to test what it claims to.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b158e0b1b1bfd2dfce6d66d67dba3c94449f9cac

Modified Files
--------------
src/test/regress/expected/alter_table.out | 32 ++++++++++++++++++++++---------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 30 insertions(+), 13 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9c1a4fc891646110fe9b306fe4103f052504d6d9

Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3383cf023484d595cc58ff47a9aa76ce5ed5bcf3

Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/294a2199a331ff719e0d0fe70fd2b6200689eb16

Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6a1396fd19a3cefc71e176931c9e02a3b12d32eb

Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix alter_table.sql test case to test what it claims to.
@ 2022-11-10 22:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-11-10 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix alter_table.sql test case to test what it claims to.

The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.

Fix that, and add the missing checks that would have exposed the
problem to begin with.

Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/421f3363a8c1035cfc2e0684bf8b24df2afe2902

Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql      | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-11-10 22:24 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>
2022-11-10 22:24 pgsql: Fix alter_table.sql test case to test what it claims to. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox