pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_dump: avoid unsafe function calls in getPolicies(). 5+ messages / 1 participants [nested] [flat]
* pgsql: pg_dump: avoid unsafe function calls in getPolicies(). @ 2021-12-31 17:48 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-12-31 17:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: avoid unsafe function calls in getPolicies(). getPolicies() had the same disease I fixed in other places in commit e3fcbbd62, i.e., it was calling pg_get_expr() for expressions on tables that we don't necessarily have lock on. To fix, restrict the query to only collect interesting rows, rather than doing the filtering on the client side. Like the previous patch, apply to HEAD only for now. Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3e6e86abca0138abd7265306beb6346dc2d9e221 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 42 +++++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pg_dump: avoid unsafe function calls in getPolicies(). @ 2022-11-19 17:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-11-19 17:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: avoid unsafe function calls in getPolicies(). getPolicies() had the same disease I fixed in other places in commit e3fcbbd62, i.e., it was calling pg_get_expr() for expressions on tables that we don't necessarily have lock on. To fix, restrict the query to only collect interesting rows, rather than doing the filtering on the client side. Back-patch of commit 3e6e86abc. That's been in v15/HEAD long enough to have some confidence about it, so now let's fix the problem in older branches. Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/03ac48549438f26b796c1f536c2b545c6c50f259 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 42 +++++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pg_dump: avoid unsafe function calls in getPolicies(). @ 2022-11-19 17:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-11-19 17:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: avoid unsafe function calls in getPolicies(). getPolicies() had the same disease I fixed in other places in commit e3fcbbd62, i.e., it was calling pg_get_expr() for expressions on tables that we don't necessarily have lock on. To fix, restrict the query to only collect interesting rows, rather than doing the filtering on the client side. Back-patch of commit 3e6e86abc. That's been in v15/HEAD long enough to have some confidence about it, so now let's fix the problem in older branches. Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a5b26aaafe4fc4ee96d09103e2692b743850c1a6 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 42 +++++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pg_dump: avoid unsafe function calls in getPolicies(). @ 2022-11-19 17:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-11-19 17:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: avoid unsafe function calls in getPolicies(). getPolicies() had the same disease I fixed in other places in commit e3fcbbd62, i.e., it was calling pg_get_expr() for expressions on tables that we don't necessarily have lock on. To fix, restrict the query to only collect interesting rows, rather than doing the filtering on the client side. Back-patch of commit 3e6e86abc. That's been in v15/HEAD long enough to have some confidence about it, so now let's fix the problem in older branches. Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1ed6f1b9116c9a478a973040319395b58b6648ad Modified Files -------------- src/bin/pg_dump/pg_dump.c | 42 +++++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: pg_dump: avoid unsafe function calls in getPolicies(). @ 2022-11-19 17:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-11-19 17:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: avoid unsafe function calls in getPolicies(). getPolicies() had the same disease I fixed in other places in commit e3fcbbd62, i.e., it was calling pg_get_expr() for expressions on tables that we don't necessarily have lock on. To fix, restrict the query to only collect interesting rows, rather than doing the filtering on the client side. Back-patch of commit 3e6e86abc. That's been in v15/HEAD long enough to have some confidence about it, so now let's fix the problem in older branches. Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b7333e826955092776108dfdb7cd358beeeca138 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 42 +++++++++++++++++++++++++++++------------- 1 file changed, 29 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-11-19 17:00 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-12-31 17:48 pgsql: pg_dump: avoid unsafe function calls in getPolicies(). Tom Lane <tgl@sss.pgh.pa.us> 2022-11-19 17:00 pgsql: pg_dump: avoid unsafe function calls in getPolicies(). Tom Lane <tgl@sss.pgh.pa.us> 2022-11-19 17:00 pgsql: pg_dump: avoid unsafe function calls in getPolicies(). Tom Lane <tgl@sss.pgh.pa.us> 2022-11-19 17:00 pgsql: pg_dump: avoid unsafe function calls in getPolicies(). Tom Lane <tgl@sss.pgh.pa.us> 2022-11-19 17:00 pgsql: pg_dump: avoid unsafe function calls in getPolicies(). Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox